Skip to content

Commit

Permalink
Merge pull request taskcluster#1489 from taskcluster/bug586114
Browse files Browse the repository at this point in the history
Change the shape of the url for the task groups
  • Loading branch information
djmitche authored Oct 4, 2019
2 parents f67c5b9 + 76faa6a commit 62ee257
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions services/github/src/handlers.js
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ async function deprecatedStatusHandler(message) {
}

debug(`Attempting to update status for ${build.organization}/${build.repository}@${build.sha} (${state})`);
const target_url = libUrls.ui(this.context.cfg.taskcluster.rootUrl, `/task-group-inspector/#/${taskGroupId}`);
const target_url = libUrls.ui(this.context.cfg.taskcluster.rootUrl, `/tasks/groups/${taskGroupId}`);
try {
await instGithub.repos.createStatus({
owner: build.organization,
Expand Down Expand Up @@ -729,7 +729,7 @@ async function taskGroupCreationHandler(message) {

const statusContext = `${this.context.cfg.app.statusContext} (${eventType.split('.')[0]})`;
const description = `TaskGroup: Pending (for ${eventType})`;
const target_url = libUrls.ui(this.context.cfg.taskcluster.rootUrl, `/task-group-inspector/#/${taskGroupId}`);
const target_url = libUrls.ui(this.context.cfg.taskcluster.rootUrl, `tasks/groups/${taskGroupId}`);

// Authenticating as installation.
const instGithub = await this.context.github.getInstallationGithub(installationId);
Expand Down
2 changes: 1 addition & 1 deletion services/github/test/handler_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ helper.secrets.mockSuite(testing.suiteName(), ['taskcluster'], function(mock, sk
helper.withFakeGithub(mock, skipping);
helper.withPulse(mock, skipping);

const URL_PREFIX = 'https://tc-tests.example.com/task-group-inspector/#/';
const URL_PREFIX = 'https://tc-tests.example.com/tasks/groups/';

let github = null;
let handlers = null;
Expand Down

0 comments on commit 62ee257

Please sign in to comment.