Skip to content

Commit

Permalink
Merge pull request taskcluster#1142 from djmitche/bug1570723
Browse files Browse the repository at this point in the history
Bug 1570723 - allow configuration of UI_LOGIN_STRATEGY_NAMES
  • Loading branch information
djmitche authored Aug 2, 2019
2 parents f030d45 + 4b68aed commit a0a579e
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 1 deletion.
5 changes: 5 additions & 0 deletions changelog/bug1570723.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
level: major
reference: bug 1570723
---
The deployment configuration value `ui.ui_login_strategy_names` is now required.
It should be a space-separated list of the names of the strategies in `web_server.ui_login_strategies`.
1 change: 1 addition & 0 deletions dev-docs/dev-config-example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -240,4 +240,5 @@ ui:
application_name: ...
graphql_subscription_endpoint: ...
graphql_endpoint: ...
ui_login_strategy_names: ...
references: {}
1 change: 1 addition & 0 deletions infrastructure/builder/src/generate/generators/k8s.js
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ const extras = {
{type: '!env', var: 'APPLICATION_NAME'},
{type: '!env', var: 'GRAPHQL_SUBSCRIPTION_ENDPOINT'},
{type: '!env', var: 'GRAPHQL_ENDPOINT'},
{type: '!env', var: 'UI_LOGIN_STRATEGY_NAMES'},
],
procs: {
web: {
Expand Down
1 change: 1 addition & 0 deletions infrastructure/k8s/templates/taskcluster-ui-secret.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion infrastructure/k8s/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -1437,13 +1437,17 @@
],
"title": "Process settings for this service",
"type": "object"
},
"ui_login_strategy_names": {
"type": "string"
}
},
"required": [
"procs",
"application_name",
"graphql_subscription_endpoint",
"graphql_endpoint"
"graphql_endpoint",
"ui_login_strategy_names"
],
"title": "Configuration options for ui",
"type": "object"
Expand Down

0 comments on commit a0a579e

Please sign in to comment.