Change api of removeWorker to match other provider methods

somchi · Oct 4, 2019 · a8f9e15 · a8f9e15
1 parent b1cdbc3
commit a8f9e15
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/services/worker-manager/src/api.js b/services/worker-manager/src/api.js
@@ -536,7 +536,7 @@ builder.declare({
   }
 
   try {
-    await provider.removeWorker(worker);
+    await provider.removeWorker({worker});
   } catch (err) {
     if (!(err instanceof ApiError)) {
       throw err;

diff --git a/services/worker-manager/src/providers/provider.js b/services/worker-manager/src/providers/provider.js
@@ -72,7 +72,7 @@ class Provider {
     throw new ApiError('not supported for this provider');
   }
 
-  async removeWorker(worker) {
+  async removeWorker({worker}) {
     throw new ApiError('not supported for this provider');
   }
 

diff --git a/services/worker-manager/src/providers/static.js b/services/worker-manager/src/providers/static.js
@@ -42,7 +42,7 @@ class StaticProvider extends Provider {
     return worker;
   }
 
-  async removeWorker(worker) {
+  async removeWorker({worker}) {
     await worker.remove();
   }
 

diff --git a/services/worker-manager/src/providers/testing.js b/services/worker-manager/src/providers/testing.js
@@ -78,7 +78,7 @@ class TestingProvider extends Provider {
     return worker;
   }
 
-  async removeWorker(worker) {
+  async removeWorker({worker}) {
     if (!worker.providerData.allowRemoveWorker) {
       throw new ApiError('removing workers is not supported for testing provider');
     }