Fix Prefix used when fetching subsequent pages with ListObjectsV2 #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Prefix that was used when fetching subsequent pages via the ContinuationToken was not the same prefix as the one used for the first page. This is incorrect, and causes the subsequent page fetches to fail.
|
In case not clear, the issue here is that the
|
jdfalk
added a commit
to jdfalk/zfsbackup-go
that referenced
this pull request
Nov 13, 2022
…h ListObjectsV2. Signed-off-by: Johnathan Falk <johnathan.falk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Prefix that was used when fetching subsequent pages via the
ContinuationToken was not the same prefix as the one used for the first
page.
This is incorrect, and causes the subsequent page fetches to fail.
So once your manifests prefix has enough entries that it needs to fetch the next page, zfsbackup-go blows up with an S3 error.
Seems fairly obvious this was a typo/omission from a skim of the code. Hopefully makes sense.