Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide package file download api #458

Closed
jbonnet opened this issue Mar 15, 2017 · 2 comments
Closed

Provide package file download api #458

jbonnet opened this issue Mar 15, 2017 · 2 comments
Assignees
Labels

Comments

@jbonnet
Copy link
Member

jbonnet commented Mar 15, 2017

All the logic is apparently available, we're only missing it in the API

@jbonnet jbonnet self-assigned this Mar 15, 2017
@jbonnet
Copy link
Member Author

jbonnet commented Mar 21, 2017

@dang03, @shuaibsiddiqui, @felipevicens
Since packages can be big files, I was thinking of connecting directly from the API to the Catalogue (i.e., without using the Package micro-service); what do you think?

This would save the time for opening/saving the package twice, first in the API (needs to validate owner, format, etc.) and second in the Package micro-service.

@jbonnet
Copy link
Member Author

jbonnet commented Mar 21, 2017

@dang03, @shuaibsiddiqui, @felipevicens
...and we should improve later 'cause we have currently 3 calls:

  1. call to get package's meta-data (gives the son_package_uuid)
  2. call to get package file's name
  3. call to get the package file

At least 1. and 2. could be merged, no? Or am I missing something?

jbonnet added a commit that referenced this issue Mar 21, 2017
…d-api

Closes #458 - not fully finished yet, due to Catalogues API constraints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant