Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added REST endpoint for packaging + fixes #98

Merged
merged 14 commits into from
Aug 21, 2019

Conversation

stefanbschneider
Copy link
Member

@stefanbschneider stefanbschneider commented Aug 16, 2019

for sdk portal: sonata-nfv/tng-portal#379

@stefanbschneider
Copy link
Member Author

@mpeuster The failure seems to be a packager unit test. Do you have an idea what's the issue? I don't really get the error output.

=================================== FAILURES ===================================

________________ TngSdkPackageRestTest.test_project_v1_endpoint ________________


self = <tngsdk.package.tests.test_unit_rest.TngSdkPackageRestTest testMethod=test_project_v1_endpoint>


    def test_project_v1_endpoint(self):

        # do a malformed post

        r = self.app.post("/api/v1/projects",

                          content_type="multipart/form-data",

                          data={"project": (None,

                                            "5gtango-ns-project-example.zip"),

                                "callback_url": "https://test.local:8000/cb",

>                               "skip_store": True})


src/tngsdk/package/tests/test_unit_rest.py:141: 

....

@stefanbschneider
Copy link
Member Author

TODO: Restart once this PR is merged: sonata-nfv/tng-sdk-package#187

@stefanbschneider
Copy link
Member Author

Todo:

  • Replace GET with POST
  • Make skip-validation optional param rather than hard-coding (could put a checkbox to the portal)

@stefanbschneider stefanbschneider merged commit 907a7f1 into sonata-nfv:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant