Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Get started fixes #4024

Merged
merged 2 commits into from
Jul 29, 2016
Merged

Doc: Get started fixes #4024

merged 2 commits into from
Jul 29, 2016

Conversation

yannickroger
Copy link
Contributor

@yannickroger yannickroger commented Jul 27, 2016

I am targeting this branch, because I am fixing bugs so it is backward compatible.

Changelog

### Fixed
- Typos in the get started doc

Subject

I did the get started doc and found a few typos. Here are fixes for them.

Step 5: Enable the "translator" service
------------------------------------

The translator service required by SonataAdmin to display all labels properly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your sentence misses a word.

@yannickroger
Copy link
Contributor Author

@greg0ire Fixed

@greg0ire
Copy link
Contributor

Thanks!

Can you have a look at the failing build? You have a very simple problem to fix before this can get merged.

@yannickroger
Copy link
Contributor Author

@greg0ire Fixed

@greg0ire
Copy link
Contributor

greg0ire commented Jul 28, 2016

LGTM and by the way, kudos on your commits, they are nice and clean :)

Regarding the subject of your PR, not sure the things you found qualify as typos…

@core23 core23 merged commit 7386ec0 into sonata-project:3.x Jul 29, 2016
@OskarStark
Copy link
Member

OskarStark commented Jul 30, 2016

This is not correct, we support Symfony 2.7, too.....

@core23
Copy link
Member

core23 commented Jul 30, 2016

Any idea how to write docs for both versions?

@greg0ire
Copy link
Contributor

I don't think we should bother about that, people that still use sf < 3 are on old projects, and are seasoned sf developers, they know what bin/console means, they can make the translation.

@OskarStark
Copy link
Member

symfony itself uses app/console instead of bin/console in docs currently

@greg0ire
Copy link
Contributor

@OskarStark
Copy link
Member

Aren't they planning to move to bin/console ?

yes but we don not fully support symfony 3.0 -> SonataUserBundle

@ju1ius
Copy link
Contributor

ju1ius commented Aug 1, 2016

Any idea how to write docs for both versions?

Maybe using the composer notation ? Like symfony-bin-dir/console, symfony-var-dir/cache at al.

// This is how you tell composer where your stuff is in composer.json
{
  "extra": {
    "symfony-app-dir": "app",
    "symfony-web-dir": "web",
    "symfony-var-dir": "var",
    "symfony-bin-dir": "bin",
    "symfony-tests-dir": "tests",
  }
}

@greg0ire
Copy link
Contributor

greg0ire commented Aug 1, 2016

yes but we don not fully support symfony 3.0 -> SonataUserBundle

You don't have to use 3.0 to be able to use the 3.0 directory structure, and I think will have to switch sometimes anyway

Maybe using the composer notation ?

Again, not sure it's worth the hassle. By using bin/console, you risk less newbies literally typing symfony-app-dir/console. Again, the only people that this is important for are newbies IMO, and there are probably more using 3.0 than older versions, don't you think?

@ju1ius
Copy link
Contributor

ju1ius commented Aug 1, 2016

Again, the only people that this is important for are newbies IMO, and there are probably more using 3.0 than older versions, don't you think?

Agree, using the most up-to-date defaults is certainly more than enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants