-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: Get started fixes #4024
Doc: Get started fixes #4024
Conversation
Step 5: Enable the "translator" service | ||
------------------------------------ | ||
|
||
The translator service required by SonataAdmin to display all labels properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your sentence misses a word.
@greg0ire Fixed |
Thanks! Can you have a look at the failing build? You have a very simple problem to fix before this can get merged. |
@greg0ire Fixed |
LGTM and by the way, kudos on your commits, they are nice and clean :) Regarding the subject of your PR, not sure the things you found qualify as typos… |
This is not correct, we support Symfony 2.7, too..... |
Any idea how to write docs for both versions? |
I don't think we should bother about that, people that still use sf < 3 are on old projects, and are seasoned sf developers, they know what |
symfony itself uses app/console instead of bin/console in docs currently |
yes but we don not fully support symfony 3.0 -> SonataUserBundle |
Maybe using the composer notation ? Like // This is how you tell composer where your stuff is in composer.json
{
"extra": {
"symfony-app-dir": "app",
"symfony-web-dir": "web",
"symfony-var-dir": "var",
"symfony-bin-dir": "bin",
"symfony-tests-dir": "tests",
}
} |
You don't have to use 3.0 to be able to use the 3.0 directory structure, and I think will have to switch sometimes anyway
Again, not sure it's worth the hassle. By using |
Agree, using the most up-to-date defaults is certainly more than enough. |
I am targeting this branch, because I am fixing bugs so it is backward compatible.
Changelog
Subject
I did the get started doc and found a few typos. Here are fixes for them.