Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Maintainers / Future of this bundle. #160

Closed
Kalyse opened this issue Apr 2, 2020 · 11 comments
Closed

Maintainers / Future of this bundle. #160

Kalyse opened this issue Apr 2, 2020 · 11 comments

Comments

@Kalyse
Copy link

Kalyse commented Apr 2, 2020

Hi,

I'll keep it short. I'm looking (over the course of next few months as a side project) implementing Elastic Search for our SonataAdmin application. We have tens of millions of entities and the current Pager QueryBuilder just makes searching things dififcult when we need to index and search on about 10 different fields. It feels like bottles on the wall with improving the performance on each query and enough is enough.

  1. Is this repo still active and would you want PRs.
  2. Is there a reason this wasn't maintained? I mean, in the sense that practically the POC turned out to be a bad idea to implement with Sonata?
  3. I cannot find anything in this bundle which includes the field mapping of a Doctrine entity to ES indices. Did any documentation get created on how best to keep the Admin entities in sync with Elastic Search and the elastic mappings?
@Kalyse Kalyse added the feature label Apr 2, 2020
@tschackmack
Copy link

Hi!
I'm very interested in this bundle. please keep it alive!

@core23
Copy link
Member

core23 commented Apr 2, 2020

1. Is this repo still active and would you want PRs.

Yes, we accept new PRs.

2. Is there a reason this wasn't maintained? 

This bundle is still (some kind of) maintained. We review PRs and accept them, but we don't develop new features by ourself nor do we actively search for bugs.

I never used this bundle myself. IMHO this bundle was just a POC which was developed some time ago and the original creator of this project lost interest.

@core23
Copy link
Member

core23 commented Apr 2, 2020

Should we deprecate this project @sonata-project/contributors ? The last non-techical PR is from 2017!

@VincentLanglet
Copy link
Member

Should we deprecate this project @sonata-project/contributors ? The last non-techical PR is from 2017!

Does developers can use something else instead ? If not, we may need to keep maintaining this project. But if none of the maintainers use this project, the interests in new feature/bug solving will not be huge... even if we'll review PR from contributors.

@core23
Copy link
Member

core23 commented Apr 2, 2020

There are just ~20 forks / stars and only 6 usages. I think we could deprecate this project without any recommendation.

@VincentLanglet
Copy link
Member

@greg0ire
Copy link
Contributor

greg0ire commented Apr 2, 2020

I never used this bundle myself. IMHO this bundle was just a POC which was developed some time ago and the original creator of this project lost interest.

AFAIK my former company still uses the POC, it just works ™️ but they're no longer big on opensource and maintaining. I'm personally willing to maintain this project, as in reviewing and merging PRs.

@Kalyse
Copy link
Author

Kalyse commented Apr 2, 2020 via email

@core23
Copy link
Member

core23 commented Jul 28, 2020

IMHO we should follow the same rule and deprecate abandon this project. We should focus our time and energy on the most popular project unless we find an active maintainer for this project.

Maintaining a project by merging a PR once in a year is no real maintenance to me. There may be some security issues or other critical issues and no one cares at the moment.

WDYT @greg0ire @VincentLanglet

@VincentLanglet
Copy link
Member

IMHO we should follow the same rule and deprecate this project. We should focus our time and energy on the most popular project unless we find an active maintainer for this project.

Maintaining a project by merging a PR once in a year is no real maintenance to me. There may be some security issues or other critical issues and no one cares at the moment.

I agree with abandon, not deprecate.

To me

  • Deprecated would say that it's not recommend to use it and we have another recommendation for users, so we won't remove the deprecated state.
  • Abandoned is just the current state of the project but it's still open to new maintainers if someone want to work on the bundle to un-abandon it.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants