Added test for SonataCoreBundle #272

codebach · 2016-05-26T15:55:13Z

Subject

Writing test to increase code coverage of SonataCoreBundle

Todo

remove @group annotations after WIP
remove @Covers annotations
line break

greg0ire · 2016-05-26T16:17:25Z

Tests/SonataCoreBundleTest.php

+                }
+
+                $this->fail(sprintf('Compiler pass is not one of the expected types. Expects "Sonata\AdminBundle\DependencyInjection\Compiler\StatusRendererCompilerPass", "Sonata\AdminBundle\DependencyInjection\Compiler\AdapterCompilerPass" or "Sonata\AdminBundle\DependencyInjection\Compiler\FormFactoryCompilerPass", but got "%s".', get_class($pass)));
+            }));


You SHOULD use Prophecy (SHOULD as in "the PR will not get refused it you don't, but it's better) ;)

AFAIK, the discussion is not over: sonata-project/dev-kit#89 :-)

Oh right, my bad!

greg0ire · 2016-05-26T16:18:10Z

Excellent initiative @ahmetakbn !

soullivaneuh · 2016-05-26T16:19:45Z

Tests/SonataCoreBundleTest.php

+{
+    /**
+     * @group core-bundle
+     * @covers Sonata\CoreBundle\SonataCoreBundle::build


Please remove @covers. We want to follow Symfony usage and they don't use it.

codebach · 2016-06-02T10:29:33Z

The only lines not being tested are these in SonataCoreBundle.php

if (class_exists('Nelmio\ApiDocBundle\Form\Extension\DescriptionFormTypeExtension')) {
    $formTypes[] = 'nelmio_api_doc.form.extension.description_form_type_extension';
}

How should I mock php native functions? any suggestions? May be this: https://github.com/php-mock/php-mock

greg0ire · 2016-06-02T10:32:50Z

I think NelmioApiDocBundle should be added to require-dev. You need to rebase to fix StyleCI.

codebach · 2016-06-02T11:32:03Z

Ok, I will add NelmioApiDocBundle to require dev. The StyleCI is failing in other files which are not related to this PR. I will open another PR for that.

soullivaneuh · 2016-06-02T11:36:22Z

No need for the PR, I'll do that with styleci.

Sullivan SENECHAL
Le 2 juin 2016 13:32, "Ahmet Akbana" notifications@github.com a écrit :

Ok, I will add NelmioApiDocBundle to require dev. The StyleCI is failing
in other files which are not related to this PR. I will open another PR for
that.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#272 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABnqNSlfm5MztYq9KHJtqbH7kUkbhKT3ks5qHr80gaJpZM4InsHv
.

greg0ire · 2016-06-02T11:36:27Z

Ok, I will add NelmioApiDocBundle to require dev. The StyleCI is failing in other files which are not related to this PR. I will open another PR for that.

Rebasing might be enough for that, I don't know…

soullivaneuh · 2016-06-02T11:42:09Z

@ahmetakbn I checked StyleCI, nothing to be changed. Be sure your local 3.x branch is sync with upstream and do a rebase again.

soullivaneuh · 2016-06-02T12:13:05Z

Ouch. I think you did a rebase from master instead of 3.x...

greg0ire · 2016-06-02T12:14:34Z

git rebase -i origin/3.x can help you get rid of the unwanted commits

codebach · 2016-06-02T13:24:12Z

Yes I didn't realize that, sorry. Now it is rebased to 3.x

OskarStark · 2016-06-02T17:15:37Z

composer.json

@@ -37,7 +37,8 @@
        "sensio/framework-extra-bundle": "^2.3 || ^3.0",
        "sonata-project/exporter": "^1.3",
        "symfony/phpunit-bridge": "^2.7",
-        "sllh/php-cs-fixer-styleci-bridge": "^2.0"
+        "sllh/php-cs-fixer-styleci-bridge": "^2.0",
+        "nelmio/api-doc-bundle": "^2.11"


why are we doing this in this PR?

See previous comment

got it, sorry

codebach · 2016-06-03T13:58:52Z

This PR is ready from my side.

soullivaneuh · 2016-06-03T14:02:08Z

Tests/SonataCoreBundleTest.php

+    /**
+     * @dataProvider getRegisteredFormMappingAndExtensions
+     *
+     * @param $mapping


Param type?

greg0ire · 2016-06-03T14:02:22Z

LGTM

soullivaneuh · 2016-06-03T14:03:10Z

@ahmetakbn I removed the changelog, this is not needed just for test changes.

soullivaneuh · 2016-06-03T14:20:26Z

In the name of the code coverage, I thank you! 👍

greg0ire · 2016-06-03T14:20:39Z

+5.4%

Nice!

OskarStark · 2016-06-03T16:44:42Z

Thank you @ahmetakbn kepp the good work 👍

SonataCI added the review required label May 26, 2016

greg0ire reviewed May 26, 2016
View reviewed changes

soullivaneuh reviewed May 26, 2016
View reviewed changes

soullivaneuh added pending author and removed review required labels May 26, 2016

SonataCI removed the pending author label May 27, 2016

codebach force-pushed the test-for-sonata-core-bundle branch from 1a1edf0 to 832596c Compare May 27, 2016 13:23

SonataCI added the review required label May 27, 2016

codebach force-pushed the test-for-sonata-core-bundle branch 5 times, most recently from d739627 to 1077b5b Compare June 2, 2016 10:22

codebach force-pushed the test-for-sonata-core-bundle branch from 1077b5b to fb5d4d3 Compare June 2, 2016 11:53

soullivaneuh added pending author and removed review required labels Jun 2, 2016

soullivaneuh added the in progress label Jun 2, 2016

codebach force-pushed the test-for-sonata-core-bundle branch from fb5d4d3 to f3d4aeb Compare June 2, 2016 13:19

SonataCI added the review required label Jun 2, 2016

SonataCI removed the pending author label Jun 2, 2016

added NelmioApiDocBundle to composer.json

cbc6c3b

codebach force-pushed the test-for-sonata-core-bundle branch from f3d4aeb to eaac5f7 Compare June 2, 2016 13:23

codebach changed the title ~~[WIP] Added test for SonataCoreBundle~~ Added test for SonataCoreBundle Jun 2, 2016

OskarStark reviewed Jun 2, 2016
View reviewed changes

codebach force-pushed the test-for-sonata-core-bundle branch from eaac5f7 to 24582ea Compare June 3, 2016 08:37

greg0ire removed the in progress label Jun 3, 2016

soullivaneuh reviewed Jun 3, 2016
View reviewed changes

Tests/SonataCoreBundleTest.php

/**

* @dataProvider getRegisteredFormMappingAndExtensions

*

* @param $mapping

Copy link

Member

soullivaneuh Jun 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Param type?

soullivaneuh added pending author pedantic and removed review required labels Jun 3, 2016

soullivaneuh removed the pending author label Jun 3, 2016

added test for SonataCoreBundle

8f11a79

codebach force-pushed the test-for-sonata-core-bundle branch from 24582ea to 8f11a79 Compare June 3, 2016 14:07

soullivaneuh added the review required label Jun 3, 2016

soullivaneuh merged commit 092c6b9 into sonata-project:3.x Jun 3, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added test for SonataCoreBundle #272

Added test for SonataCoreBundle #272

codebach commented May 26, 2016 •

edited by soullivaneuh

Loading

greg0ire May 26, 2016

soullivaneuh May 26, 2016

greg0ire May 26, 2016

greg0ire commented May 26, 2016

soullivaneuh May 26, 2016

codebach commented Jun 2, 2016

greg0ire commented Jun 2, 2016

codebach commented Jun 2, 2016

soullivaneuh commented Jun 2, 2016

greg0ire commented Jun 2, 2016

soullivaneuh commented Jun 2, 2016

soullivaneuh commented Jun 2, 2016

greg0ire commented Jun 2, 2016

codebach commented Jun 2, 2016

OskarStark Jun 2, 2016

greg0ire Jun 2, 2016

OskarStark Jun 2, 2016

codebach commented Jun 3, 2016

soullivaneuh Jun 3, 2016

greg0ire commented Jun 3, 2016

soullivaneuh commented Jun 3, 2016

soullivaneuh commented Jun 3, 2016

greg0ire commented Jun 3, 2016

OskarStark commented Jun 3, 2016

Added test for SonataCoreBundle #272

Added test for SonataCoreBundle #272

Conversation

codebach commented May 26, 2016 • edited by soullivaneuh Loading

Subject

Todo

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

greg0ire commented May 26, 2016

Choose a reason for hiding this comment

codebach commented Jun 2, 2016

greg0ire commented Jun 2, 2016

codebach commented Jun 2, 2016

soullivaneuh commented Jun 2, 2016

greg0ire commented Jun 2, 2016

soullivaneuh commented Jun 2, 2016

soullivaneuh commented Jun 2, 2016

greg0ire commented Jun 2, 2016

codebach commented Jun 2, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codebach commented Jun 3, 2016

Choose a reason for hiding this comment

greg0ire commented Jun 3, 2016

soullivaneuh commented Jun 3, 2016

soullivaneuh commented Jun 3, 2016

greg0ire commented Jun 3, 2016

OskarStark commented Jun 3, 2016

codebach commented May 26, 2016 •

edited by soullivaneuh

Loading