-
-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added test for SessionDownloadStrategy #1015
Conversation
@greg0ire can you please have a look? |
Thanks for your contribution! Please monitor this thread : sonata-project/dev-kit#89 (and vote if you have an opinion on it) |
{ | ||
public function testIsGrantedFalseWithContainerHasNoSession() | ||
{ | ||
$container = $this->getMock('Symfony\Component\DependencyInjection\ContainerInterface'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So… we're depending on the whole container in this class 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! |
patch or not? @greg0ire If travis is green we can merge this! |
No new feature, no BC-break, and uncovered code can be considered a bug, so yeah, totally patch. |
I close this PR because I will change this test and create a PR to master: |
Replaces #999
Subject
Test for
SonataMediaBundle/Security/SessionDownloadStrategy