added test for SessionDownloadStrategy #1015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
changed the title
|
@greg0ire can you please have a look? |
|
Thanks for your contribution! Please monitor this thread : sonata-project/dev-kit#89 (and vote if you have an opinion on it) |
| { | ||
| public function testIsGrantedFalseWithContainerHasNoSession() | ||
| { | ||
| $container = $this->getMock('Symfony\Component\DependencyInjection\ContainerInterface'); |
There was a problem hiding this comment.
So… we're depending on the whole container in this class 😞
There was a problem hiding this comment.
|
LGTM ! |
|
patch or not? @greg0ire If travis is green we can merge this! |
|
No new feature, no BC-break, and uncovered code can be considered a bug, so yeah, totally patch. |
|
I close this PR because I will change this test and create a PR to master: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #999
Subject
Test for
SonataMediaBundle/Security/SessionDownloadStrategy