Allow "friendsofsymfony/rest-bundle:^3.0" #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
wbloszyk
force-pushed
the
support_rest_3
branch
from
b47320d to
1c59034
Compare
phansys
requested changes
Aug 1, 2020
| @@ -13,7 +13,8 @@ | |||
|
|
|||
| namespace Sonata\PageBundle\Controller\Api; | |||
|
|
|||
| use FOS\RestBundle\Controller\Annotations\View; | |||
| use FOS\RestBundle\Controller\Annotations as Rest; | |||
| use FOS\RestBundle\View\View as FOSRestView; | |||
There was a problem hiding this comment.
It is much easier to read this be people with less knowlage about REST and nelmio/api-doc.
There was a problem hiding this comment.
I think we should not create aliases when they are not required.
wbloszyk
force-pushed
the
support_rest_3
branch
from
1c59034 to
f1b3105
Compare
wbloszyk
force-pushed
the
support_rest_3
branch
from
f1b3105 to
12a05fb
Compare
wbloszyk
force-pushed
the
support_rest_3
branch
5 times, most recently
from
9fcbf57 to
0795b30
Compare
|
@phansys @jordisala1991 Can you check it and ping contributors? It is RTM. |
core23
reviewed
Aug 18, 2020
wbloszyk
force-pushed
the
support_rest_3
branch
from
0795b30 to
4f6ec8a
Compare
phansys
approved these changes
Aug 18, 2020
core23
approved these changes
Aug 19, 2020
VincentLanglet
approved these changes
Aug 19, 2020
|
Thanks @wbloszyk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Allow "friendsofsymfony/rest-bundle:^3.0".
I am targeting this branch, because these changes respect BC.
Changelog