Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Dutch translations #1230

Merged
merged 4 commits into from
Dec 9, 2020
Merged

update Dutch translations #1230

merged 4 commits into from
Dec 9, 2020

Conversation

zghosts
Copy link
Contributor

@zghosts zghosts commented Oct 31, 2020 •
edited by OskarStark
Loading

Updates the Dutch translations

I am targeting this branch, because it only updates translations

Changelog

### Changed
- Update Dutch translations

core23
core23 previously approved these changes Oct 31, 2020
View reviewed changes
@core23 core23 added the patch label Oct 31, 2020
@VincentLanglet
Copy link
Member

Same than here: sonata-project/SonataMediaBundle#1853 (comment)

I'm not sure about the xlf part.
Since you're the one who added them: e68286f maybe you can explain why a xlf file instead of the xliff one @core23 ? :)

@OskarStark
Copy link
Member

It should be renamed to xliff

VincentLanglet
VincentLanglet previously approved these changes Nov 2, 2020
View reviewed changes
@zghosts
Copy link
Contributor Author

zghosts commented Nov 2, 2020 •
edited
Loading

Changed.
On a sidenote, can you keep the hacktoberfest label on the repositories, or label PR's done during hacktoberfest as "hacktoberfest-accepted" since it seems they are longer counted. thanks!

@VincentLanglet VincentLanglet requested a review from a team November 2, 2020 12:06
@VincentLanglet VincentLanglet reopened this Dec 5, 2020
@VincentLanglet
Copy link
Member

Hi @zghosts Can you fix the test

Thanks :)

@OskarStark OskarStark closed this Dec 9, 2020
@OskarStark OskarStark reopened this Dec 9, 2020
@OskarStark
Copy link
Member

Can you please rebase on 3.x? And check a last xml error?

@zghosts zghosts force-pushed the feature/dutch-translations branch from 5378a4b to c06463f Compare December 9, 2020 09:59
@zghosts
Copy link
Contributor Author

zghosts commented Dec 9, 2020

That should do it, pending tests

@OskarStark OskarStark merged commit da7ce55 into sonata-project:3.x Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet left review comments

@core23 core23 core23 left review comments

Assignees
No one assigned
Labels
hacktoberfest patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zghosts @VincentLanglet @OskarStark @core23