Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phpstan #1742

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Fix phpstan #1742

merged 1 commit into from
Dec 12, 2023

Conversation

eerison
Copy link
Contributor

@eerison eerison commented Dec 12, 2023

Remove return null from src/CmsManager/CmsPageManager::findContainer

Changelog

### Removed
- Removed the return type `null` for `src/CmsManager/CmsPageManager::findContainer`,

@eerison
Copy link
Contributor Author

eerison commented Dec 12, 2023

@VincentLanglet

@VincentLanglet VincentLanglet merged commit 13e5c1d into sonata-project:4.x Dec 12, 2023
24 checks passed
@eerison eerison deleted the fix-phpstan branch December 12, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
pedantic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eerison @VincentLanglet