This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
[MASSEMBLY-617] add ability to give a fileSuffix to a AbstractPlexusI… #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oResourceCollection
michael-o
reviewed
Jun 21, 2018
| @@ -149,6 +149,8 @@ private void addResources( List<PlexusIoResource> result, String[] resources, | |||
| for ( String name : resources ) | |||
| { | |||
| String sourceDir = name.replace( '\\', '/' ); | |||
|
|
|||
| name = addFileNameSuffix(name); | |||
| @@ -185,6 +187,7 @@ private void addResourcesJava7( List<PlexusIoResource> result, String[] resource | |||
| for ( String name : resources ) | |||
| { | |||
| String sourceDir = name.replace( '\\', '/' ); | |||
| name = addFileNameSuffix(name); | |||
| private String addFileNameSuffix(String name) | ||
| { | ||
| String nameWithSuffix = name; | ||
| if (getFileSuffix() != null && getFileSuffix() != "") |
There was a problem hiding this comment.
Please use StringUtils from Plexus Utils here.
| { | ||
| String[] split = name.split("\\."); | ||
| String extension = "." + split[split.length-1]; | ||
| nameWithSuffix = name.replace(extension, getFileSuffix() + extension); |
There was a problem hiding this comment.
This block is not reliable. What about tar.gz or similar?
There was a problem hiding this comment.
You're right, I'll fix this, but I must write a rule, I add javadoc explanation
|
And I have swtich the PR here : codehaus-plexus/plexus-io#13 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oResourceCollection
Hi
In order to fix https://issues.apache.org/jira/browse/MASSEMBLY-617, I need to add a capability to PlexusIoFileResourceCollection, to add file suffix when it package files.
This PR add this feature.
Tell me if something goes wrong
Thx