feat: support smtp without auth #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoQuote
force-pushed
the
support-smtp-no-auth
branch
from
b08b8fd
to
90438d1
Compare
|
@songquanpeng 大佬看看这个 |
|
不好意思哈这周没来及看 |
|
@songquanpeng 大佬有空看看 |
LeoQuote
force-pushed
the
support-smtp-no-auth
branch
from
90438d1
to
9b00325
Compare
songquanpeng
changed the title
|
我重新整理下吧，是不需要这个air主题的修改吧 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1101 +/- ##
========================================
- Coverage 1.09% 1.09% -0.01%
========================================
Files 130 130
Lines 9690 9698 +8
========================================
Hits 106 106
- Misses 9570 9578 +8
Partials 14 14 ☔ View full report in Codecov by Sentry. |
|
可以分开吗 |
LeoQuote
force-pushed
the
support-smtp-no-auth
branch
from
af79b07
to
54baef0
Compare
|
分开了, 这个逻辑不太好加测试, 要测试只能集成测试, 要集成到 CI 里还挺麻烦的 |
|
thx~ |
jinjianming
pushed a commit
to jinjianming/one-api
that referenced
this pull request
Jul 17, 2024
mxdlzg
pushed a commit
to mxdlzg/one-api
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
某些 smtp 服务器不需认证(如内部的 postfix ), 在传递了 auth 信息后, 会报错显示
smtp: server doesn't support AUTH本 pr 会解决这个问题
我已确认该 PR 已自测通过，相关截图如下：