feat: add field stop in GeneralOpenAIRequest #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
可以按照openai的文档里的顺序放置stop字段吗？ |
好的，我调整一下，辛苦作者 review。 |
已根据 openai 的文档调整 stop 字段的位置，请作者查收。 |
|
thx |
jinjianming
pushed a commit
to jinjianming/one-api
that referenced
this pull request
Jul 17, 2024
mxdlzg
pushed a commit
to mxdlzg/one-api
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题描述：使用【模型重定向】功能后，one-api 转发对话时丢失 stop 参数。
翻查代码，定位到：
当
isModelMapped为真，shouldResetRequestBody也为真，调用jsonStr, err := json.Marshal(textRequest)将textRequest序列化成字符串。由于
textRequest的类型GeneralOpenAIRequest并不包含stop字段，导致模型重定向后字段丢失。close #1558
在 issue 搜索了一下，这个 issue 可能遇到类似的情况：
#1558
我已确认该 PR 已自测通过，相关截图如下：
