[libsai] Re-implement APIs create/remove #653
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Commenter does not have sufficient privileges for PR 653 in repo sonic-net/DASH |
jimmyzhai
force-pushed
the
libsai_create_remove
branch
from
d7f18a9 to
28dabbe
Compare
|
/azp run |
|
Commenter does not have sufficient privileges for PR 653 in repo sonic-net/DASH |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 653 in repo sonic-net/DASH |
jimmyzhai
force-pushed
the
libsai_create_remove
branch
from
5c2bc0b to
6b8b884
Compare
|
/azp run |
|
Commenter does not have sufficient privileges for PR 653 in repo sonic-net/DASH |
jimmyzhai
force-pushed
the
libsai_create_remove
branch
from
6b8b884 to
8b334c3
Compare
|
/azp run |
|
Commenter does not have sufficient privileges for PR 653 in repo sonic-net/DASH |
kcudnik
reviewed
Dec 20, 2024
dash-pipeline/SAI/src/p4meta.cpp
Outdated
Comment on lines
27
to
37
| { | ||
| for (auto i=0u; i<keys.size(); i++) { | ||
| if (key_name == keys[i].name) { | ||
| return &keys[i]; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
over entire PR incosistent placemtn { once in end of function once in new line, over all project has { in new line
kcudnik
reviewed
Dec 20, 2024
dash-pipeline/SAI/src/p4meta.cpp
Outdated
| get_attr_value_from_p4(key.field, key.bitwidth, mf_optional, value); | ||
| } | ||
| else { | ||
| assert(0); |
There was a problem hiding this comment.
some error message would be nice
kcudnik
reviewed
Dec 20, 2024
dash-pipeline/SAI/src/p4meta.h
Outdated
| } | ||
| else if (field == "u64") { | ||
| uint64_t val = *(const uint64_t*)v; | ||
| if (*reinterpret_cast<const char*>("\0\x01") == 0) { // Little Endian |
There was a problem hiding this comment.
A quick approach to checking host arch endianness, from https://github.com/sonic-net/DASH/blob/main/dash-pipeline/SAI/src/utils.h#L143.
There was a problem hiding this comment.
please don't use that, use proper macros/functions defined endian.h? and make proper function for that if you need running time host endian
jimmyzhai
force-pushed
the
libsai_create_remove
branch
from
8b334c3 to
93e8cca
Compare
|
/azp run |
|
Commenter does not have sufficient privileges for PR 653 in repo sonic-net/DASH |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 653 in repo sonic-net/DASH |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #651, refactor APIs create/remove for easier read and maintenance:
DashSai::createandDashSai::removeto implement them for all SAI objects/entriesThe generated sample code of APIs create/remove attribute is as below:
SAI object objectID
SAI object entry
