Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP interface loopback action HLD #1006

Merged
merged 11 commits into from
Jun 7, 2022

Conversation

liorghub
Copy link
Contributor

@liorghub liorghub commented May 25, 2022

This HLD document is describing IP interface loopback action feature.

Related PRs:

PR title State Dependencies Unitest Owner
[yang] Add IP interface loopback action related content to YANG models GitHub issue/pull request detail None Done, part of the PR @liorghub
[utilities] Add support for IP interface loopback action GitHub issue/pull request detail None Done, part of the PR @liorghub
[swss] Add support for IP interface loopback action GitHub issue/pull request detail None Done, part of the PR @liorghub
Add rif loopback action test plan GitHub issue/pull request detail None N/A @nhe-NV
Add loopback action test cases GitHub issue/pull request detail None N/A @nhe-NV

@zhangyanzhao zhangyanzhao requested a review from prsunny May 26, 2022 16:59
## 3.2 System tests
Add the following test in sonic-mgmt.
1. Create IP interface Ethernet.
2. Loopback action not configured, send traffic, verify lopbacked packets are forwarded (SAI default).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loopback -> typo. Please fix other places as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in all places.


5. The configured loopback action can be viewed by show command in CLI.
6. When SONiC configuration of loopback action is missing the system will behave as it is today, based on SAI behavioural model, forward the loopbacked packets.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a section to specify - no change to kernel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@dprital
Copy link

dprital commented Jun 2, 2022

@prsunny - can you please mark this HLD as approved ?

@liat-grozovik liat-grozovik merged commit 5f7ea7c into sonic-net:master Jun 7, 2022
@prsunny
Copy link
Contributor

prsunny commented Jun 7, 2022

Please also update the sonic-mgmt PR in description when ready

@liorghub
Copy link
Contributor Author

Please also update the sonic-mgmt PR in description when ready

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants