Isis configuration support #1234

cchoate54 · 2023-01-26T23:11:57Z

Here is the documentation to describe the initial changes proposed to introduce FRR-ISIS configuration to SONiC.

Enable isisd and add ISIS Config Support.

Repo	PR title	State
sonic-buildimage	Enable isisd and add ISIS config Support	![GitHub issue/pull request detail](https://img.shields.io/github/pulls/detail/state/Azure/sonic-buildimage/13527 [img.shields.io])
sonic-utilities	ISIS show command	![GitHub issue/pull request detail](https://img.shields.io/github/pulls/detail/state/Azure/sonic-utilities/2685 [img.shields.io])

Update frr-isis-sonic-yang-model-hld.md to include isis interface auth

syntax update

rlhui · 2023-02-11T22:26:19Z

doc/isis/frr-isis-sonic-config-support-hld.md

+
+Following section describes the changes to DB.
+
+Added new configuration tables specific to FRR_ISIS features:


Would you be adding more details for each of these tables, and also define the schema?

doc/isis/frr-isis-sonic-yang-model-hld.md defines these tables

rlhui · 2023-02-11T22:31:39Z

doc/isis/frr-isis-sonic-config-support-hld.md

+
+#### CLI/YANG Model Enhancements
+
+There are no CLI changes made in this feature thus far.


Some basic CLI's should be planned.

Added some new cli support

zhangyanzhao · 2023-03-03T22:26:47Z

@cchoate54 can you please add the code PRs by referring to #806 ? Thanks.

venkatmahalingam · 2023-04-25T06:14:10Z

doc/isis/frr-isis-sonic-config-support-hld.md

+
+sonic:~$ show run isis  --config_db 
+{ 
+  "ISIS_GLOBAL": { 


Can we include VRF as the key in the initial schema itself? we can support just default VRF for now. This will help to extend the support easily for user VRF in the future.

Included support for VRF similarly to how it was supported in the sonic-bgp-global yang model

venkatmahalingam · 2023-04-25T06:44:46Z

doc/isis/frr-isis-sonic-yang-model-hld.md

+ISIS Level Yang container is sonic-isis.yang.
+
+```
+        container ISIS_LEVEL {


Suggest to use the name ISIS_LEVELS

Updated the container name to ISIS_LEVELS

venkatmahalingam · 2023-04-25T06:48:07Z

doc/isis/frr-isis-sonic-yang-model-hld.md

+                }
+
+                leaf ifname {
+                    type string;


We should leafref to INTERFACE table.

Updated the type to leafref interface tables FRR would consider in-scope: PORT, PORTCHANNEL, and LOOPBACK_INTERFACE

venkatmahalingam · 2023-04-25T06:51:19Z

doc/isis/frr-isis-sonic-yang-model-hld.md

+```
+
+##### SONiC ISIS Defined Types
+Types defined in sonic-types.yang.j2.


Suggest to just follow typedefs from standard openconfig model
https://github.com/openconfig/public/blob/master/release/models/isis/openconfig-isis-types.yang

All defined ISIS types are now from openconfig isis types

venkatmahalingam · 2023-04-25T06:53:42Z

doc/isis/frr-isis-sonic-yang-model-hld.md

+                key "instance level_number";
+
+                leaf instance {
+                    type string;


Please use leafref to instance present in global table.

ISIS_LEVELS and ISIS_GLOBALS can be configured independently of each other based on FRR allowed behavior. I added a must statement to make sure they are always the same instance value.

venkatmahalingam · 2023-04-25T06:53:50Z

doc/isis/frr-isis-sonic-yang-model-hld.md

+                key "instance ifname";
+
+                leaf instance {
+                    type string;


Please use leafref to instance present in global table.

Added a leafref to instance in either ISIS_LEVELS or ISIS_GLOBAL

dgsudharsan · 2023-04-25T15:15:45Z

doc/isis/frr-isis-sonic-config-support-hld.md

+- FRR-ISIS config template files and isisd enabled by default in the FRR container
+  - /dockers/docker-fpm-frr
+- Enable ISIS trap messages
+  - /files/image_config/copp


Please capture the copp section. Please ensure trap is installed only when feature is enabled

Based on https://github.com/sonic-net/SONiC/blob/master/doc/copp/CoPP%20Config%20and%20Management.md , it seems we should be able to add isis to the COPP_TRAP table only when needed. Would this be a sufficient solution for now ?

Yes. Please add it on run time by updating COPP_TRAP entry. Please check is as example

https://github.com/sonic-net/sonic-ztp/pull/37/files

Added a step to add/remove 'isis' in the COPP_TRAP entry on bgp container startup when frr_mgmt_framework_config is updated

zhangyanzhao · 2023-04-25T16:02:38Z

community review recording https://zoom.us/rec/share/tHWVKfn1VXDl9tlYRFezxTUtTcZ4QKlt8DCz2hYuR-S2aNelacjCqmOUMicTpRo.mKL3EctOVqP1y9EB

andriy-kokhan · 2023-04-25T16:20:18Z

I believe that in an ideal case it would be great to have systemd service per routing protocol and also systemd target that groups these services. This could provide the best flexibility. E.g.,

routing.target
   bgp.service
   isis.service
   ospf.service

That's the way how we group SONiC services with sonic.target at the moment.
With this approach we can even implement a case with the static routes only (no routing protocols) which can be applicable for the mgmt switches.

…ction about the copp_table exemption

…te54/SONiC-fork into isis_configuration_support

cchoate54 · 2023-05-12T16:13:29Z

@venkatmahalingam and @dgsudharsan can you please review the changes made based on your suggestions

… table of FRR container startup

…te54/SONiC-fork into isis_configuration_support

venkatmahalingam · 2023-05-20T06:07:25Z

doc/isis/frr-isis-sonic-yang-model-hld.md

+                        type string {
+                            pattern "default";
+                        }
+                        type leafref {


Do we have ISIS support for user VRF as well? if yes, why do we have max-elements 1 at line 225?

This was added based on the FRR documentation mentioning "isisd does not yet support multiple ISIS processes but you must specify the name of ISIS process" in https://docs.frrouting.org/en/latest/isisd.html

@venkatmahalingam what are your thoughts here ?

zhangyanzhao · 2023-06-29T06:07:41Z

Moved from 202305 release to 202311.

zhangyanzhao · 2023-11-14T07:13:19Z

@cchoate54 can you please help to double check if all comments have been addressed? We need reviewers to approve this PR if no additional comments. Thanks.

zhangyanzhao · 2024-02-05T07:45:23Z

no update, move to backlog

QupinghaoNN · 2024-08-08T12:55:00Z

@cchoate54 Can configuration be done through the CLI of sonic-utilities to write to config_db, or can it only be done through REST or gNMI in the management framework?

cchoate54 added 2 commits January 26, 2023 15:06

Create frr-isis-sonic-config-support-hld.md

1976bdf

Create frr-isis-sonic-yang-model-hld.md

232d52f

zhangyanzhao requested a review from rlhui January 26, 2023 23:45

cchoate54 added 2 commits January 27, 2023 16:33

Update frr-isis-sonic-yang-model-hld.md

3284f5a

Update frr-isis-sonic-yang-model-hld.md to include isis interface auth

Update frr-isis-sonic-yang-model-hld.md

073e720

syntax update

rlhui reviewed Feb 11, 2023

View reviewed changes

cchoate54 added 3 commits March 2, 2023 11:56

Update to include reference diagram and new cli commands

2386d7e

Updating document to fix a small type discrepancy

dea09fd

Small update to 'show isis interface'

531ef1a

cchoate54 and others added 4 commits March 15, 2023 19:38

Small typo fix

2fb5762

Update level to level-number

ba9cfdd

Update the documentation to reflect the latest version of the feature

6d71762

Merge branch 'master' into isis_configuration_support

cd1b14e

cchoate54 marked this pull request as ready for review April 24, 2023 20:38

cchoate54 mentioned this pull request Apr 24, 2023

[DRAFT] sonic-utilities: Create SONiC ISIS show commands sonic-net/sonic-utilities#2685

Open

venkatmahalingam reviewed Apr 25, 2023

View reviewed changes

dgsudharsan reviewed Apr 25, 2023

View reviewed changes

cchoate54 and others added 3 commits May 11, 2023 19:05

Addressing PR comments on yang model changes and including a small se…

c7f54e1

…ction about the copp_table exemption

Merge branch 'isis_configuration_support' of https://github.com/cchoa…

f006d73

…te54/SONiC-fork into isis_configuration_support

Merge branch 'master' into isis_configuration_support

e5e62ff

Addressing PR comments to add a section on adding 'isis' to COPP_TRAP…

0b93309

… table of FRR container startup

Merge branch 'isis_configuration_support' of https://github.com/cchoa…

4c63808

…te54/SONiC-fork into isis_configuration_support

venkatmahalingam reviewed May 20, 2023

View reviewed changes

zhangyanzhao assigned cchoate54 Jun 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Isis configuration support #1234

Isis configuration support #1234

cchoate54 commented Jan 26, 2023 •

edited

Loading

rlhui Feb 11, 2023

cchoate54 Feb 13, 2023

rlhui Feb 11, 2023

cchoate54 Apr 24, 2023

zhangyanzhao commented Mar 3, 2023

venkatmahalingam Apr 25, 2023 •

edited

Loading

cchoate54 May 12, 2023

venkatmahalingam Apr 25, 2023

cchoate54 May 12, 2023

venkatmahalingam Apr 25, 2023

cchoate54 May 12, 2023

venkatmahalingam Apr 25, 2023

cchoate54 May 12, 2023

venkatmahalingam Apr 25, 2023

cchoate54 May 12, 2023

venkatmahalingam Apr 25, 2023

cchoate54 May 12, 2023

dgsudharsan Apr 25, 2023

cchoate54 May 12, 2023

dgsudharsan May 15, 2023

cchoate54 May 18, 2023

zhangyanzhao commented Apr 25, 2023

andriy-kokhan commented Apr 25, 2023

cchoate54 commented May 12, 2023

venkatmahalingam May 20, 2023 •

edited

Loading

cchoate54 May 22, 2023

cchoate54 Jun 6, 2023

zhangyanzhao commented Jun 29, 2023

zhangyanzhao commented Nov 14, 2023

zhangyanzhao commented Feb 5, 2024

QupinghaoNN commented Aug 8, 2024


		Following section describes the changes to DB.

		Added new configuration tables specific to FRR_ISIS features:


		#### CLI/YANG Model Enhancements

		There are no CLI changes made in this feature thus far.

Isis configuration support #1234

Are you sure you want to change the base?

Isis configuration support #1234

Conversation

cchoate54 commented Jan 26, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhangyanzhao commented Mar 3, 2023

venkatmahalingam Apr 25, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhangyanzhao commented Apr 25, 2023

andriy-kokhan commented Apr 25, 2023

cchoate54 commented May 12, 2023

venkatmahalingam May 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhangyanzhao commented Jun 29, 2023

zhangyanzhao commented Nov 14, 2023

zhangyanzhao commented Feb 5, 2024

QupinghaoNN commented Aug 8, 2024

cchoate54 commented Jan 26, 2023 •

edited

Loading

venkatmahalingam Apr 25, 2023 •

edited

Loading

venkatmahalingam May 20, 2023 •

edited

Loading