Add DPU dark-mode definition for SmartSwitch PMON #1818
Conversation
vvolam
requested review from
rameshraghupathy,
oleksandrivantsiv and
prgeor
|
Changes approved, @prgeor would you want to merge? |
There was a problem hiding this comment.
@vvolam can you elaborate the flow for honoring the flow for the graceful handling of DPU dark mode.
For dark mode to be enabled by default, platform needs to have either admin disabled by default. How is the flow handled if 'admin' disabled is missing in the config DB?
Please provide following details as to how/which context the following are done
- Detecting DPU needs to be in ADMIN down/UP
- Graceful shutdown of sonic host services on the DPU
- Invoking the platform API to do the admin down to be implemented by each platform vendor
| @@ -74,11 +74,14 @@ The picture below highlights the PMON vertical and its association with other lo | |||
| #### Use case | |||
| * Switch: Day0 setup, Maintenance, RMA | |||
| * DPU: Day0, Day1-N Provisioning, Maintenance, RMA | |||
| #### DPU dark mode | |||
| * When a DPU is in dark mode, it remains powered down and does not consume any power. | |||
| * Dark mode is enabled by default, but can be configured through the platform's config_db if needed. | |||
There was a problem hiding this comment.
It will be appropriate to say "When a DPU is in dark mode, it remains powered down and does not consume power"
"Dark mode is enabled by default, but the platform can be configure to boot in light up mode with one or more DPUs"
| * DPU "admin_status: up" is set in the configDB. When not explicitly configured the default is "up". | ||
| * The switch PMON gets the admin up notification from the configDB | ||
| * If the DPU's "admin_status: down" in the configDB, the DPU will remain powered down. The default setting is "down". | ||
| * If the DPU "admin_status: up" is set in the configDB, the switch PMON receives an admin-up notification from the configDB. |
There was a problem hiding this comment.
If the DPU "admin_status: up" or if "admin_status: down" is not configured in the configDB, the switch PMON receives an admin-up notification from the configDB.
|
@vvolam are we planning to merge this? |
Add DPU dark-mode definition and default value