Fix api query when unspecified api passed

sonic-net · Aug 23, 2021 · e7e1d80 · e7e1d80
1 parent cd93183
commit e7e1d80
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/lib/sai_redis_interfacequery.cpp b/lib/sai_redis_interfacequery.cpp
@@ -95,6 +95,13 @@ sai_status_t sai_api_query(
         return SAI_STATUS_INVALID_PARAMETER;
     }
 
+    if (sai_api_id == SAI_API_UNSPECIFIED)
+    {
+        SWSS_LOG_ERROR("api ID is unspecified api");
+
+        return SAI_STATUS_INVALID_PARAMETER;
+    }
+
     if (sai_metadata_get_enum_value_name(&sai_metadata_enum_sai_api_t, sai_api_id))
     {
         *api_method_table = ((void**)&redis_apis)[sai_api_id - 1];

diff --git a/vslib/sai_vs_interfacequery.cpp b/vslib/sai_vs_interfacequery.cpp
@@ -92,6 +92,13 @@ sai_status_t sai_api_query(
         return SAI_STATUS_INVALID_PARAMETER;
     }
 
+    if (sai_api_id == SAI_API_UNSPECIFIED)
+    {
+        SWSS_LOG_ERROR("api ID is unspecified api");
+
+        return SAI_STATUS_INVALID_PARAMETER;
+    }
+
     if (sai_metadata_get_enum_value_name(&sai_metadata_enum_sai_api_t, sai_api_id))
     {
         *api_method_table = ((void**)&vs_apis)[sai_api_id - 1];