Edgecore 4630/5835/7326/7816 API2.0 platform support #10053
Conversation
…thon3.9 in install script.
- Add missing fan drawer component to sonic_platform - Remove kernel version specification from Makefile - Update to 4630 utility
- Fix compile issue with 4630 driver modules (set_fs, get_fs, no longer supported in kernel 5.10)
- Fix SFP info dict key for 7xxx switches
- Fix 7326 driver file using old kernel function
|
@prgeor This PR is for API2.0 support. Can you point me to an example for sfp refactor using API2.0 only? |
|
|
This pull request introduces 2 alerts and fixes 6 when merging 06cee0b into afa18e2 - view on LGTM.com new alerts:
fixed alerts:
|
|
@prgeor I have not checked in any files yet but I am getting different SFP decode output after the refactoring. Before refactoring: Is this expected? |
@jeffhtgt I can see few 'Unknown' for new fields. can you check the eeprom dump of the sfp? rest looks ok to me. |
|
@prgeor Dump below. Notice the "before" and "after" output of same SFP with SfpBase (before) and Optoe (after). root@t9847swta0003:/sys/bus/i2c/devices/20-0050# od -x eeprom |
i don't see "before" and "after" labelled. What issue do you see? |
|
@prgeor I was referring to comment with the decoded/show output. The decode doesn't seem to be happening on some items with the refactored code. |
|
@prgeor Let me be more specific regarding the output. With SfpBase support these fields are displayed: With refactoring, these are displayed instead of the above: If this is expected, I will move onto converting the other 3 switch platforms. |
@jeffhtgt please proceed with sfp-refactor. we can raise bug if any issue. |
|
@prgeor See new commit. All 4 platforms were tested with new SFP refactoring updates. |
|
@jeffhtgt could you resolve the merge conflict? |
|
@prgeor Conflicts fixed. |
|
This pull request introduces 2 alerts and fixes 5 when merging 993c48e into 28f6a51 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request fixes 5 alerts when merging 2068e66 into 004dc69 - view on LGTM.com fixed alerts:
|
| else: | ||
| return False | ||
|
|
||
| def get_rx_los(self): |
There was a problem hiding this comment.
why override this? the Sfp-refactor implements this in platform-independent way. get_tx_disable() tx_disable_channel() set_power_override(), get_rx_los()? Why can't sfp-refactor access SFP eeprom in your platofrm?
There was a problem hiding this comment.
The functions I left in also use the platform CPLD. I removed any functions that completely used eeprom only.
Why I did it
Complete platform changes for AS4630-pe, AS5835-X, AS7326, AS7816 switch models (currently broken in master).
How I did it
Added proper support in sonic-buildimage repo in platform/broadcom/ and device/accton/.
How to verify it
Verified with the following commands:
Which release branch to backport (provide reason below if selected)
Description for the changelog
Add API2.0 support/fixes for the following Edgecore/Accton switch models:
Link to config_db schema for YANG module changes
N/A
A picture of a cute animal (not mandatory but encouraged)