Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRCM SAI 6.0.0.13-3] Fix Warm-reboot issue #10225

Merged
merged 1 commit into from
Mar 15, 2022
Merged

[BRCM SAI 6.0.0.13-3] Fix Warm-reboot issue #10225

merged 1 commit into from
Mar 15, 2022

Conversation

gechiang
Copy link
Collaborator

@gechiang gechiang commented Mar 11, 2022

This is to fix BRCM SAI 6.0.0.13-3 warm-reboot issue on BRCM platforms.

Preliminary tests look fine. BGP neighbors were all up with proper routes programmed
interfaces are all up
Manually ran the following test cases on DX010(TH) T0 DUT and all passed:

     fib/test_fib.py
     vxlan/test_vxlan_decap.py
     fdb/test_fdb.py
     decap/test_decap.py
     acl/null_route/test_null_route_helper.py
     vlan/test_vlan.py
     manual test on wam-reboot and fast-reboot

This fixes (#9898)

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

[BRCM SAI 6.0.0.13-3] Fix Warm-reboot issue

A picture of a cute animal (not mandatory but encouraged)

@gechiang gechiang requested a review from xumia March 14, 2022 21:36
@gechiang
Copy link
Collaborator Author

gechiang commented Mar 14, 2022

@xumia The build failure seems to be saying it is not able to find the libsaibcm debian for 6.0.0.13-3 Is there something wrong with the automatic sonic-storage upload? Can you help take a look?

[ cached ] [ target/debs/buster/libnl-3-200_3.5.0-1_amd64.deb-install ] 
[ finished ] [ target/debs/buster/libsaibcm_6.0.0.13-3_amd64.deb ] 
[ FAIL LOG START ] [ target/debs/buster/libsaibcm_6.0.0.13-3_amd64.deb ]
[ REASON ] :      target/debs/buster/libsaibcm_6.0.0.13-3_amd64.deb does not exist  
[ FLAGS  FILE    ] : [] 
[ FLAGS  DEPENDS ] : [broadcom amd64 buster 4f1655a58444e2961e7061d8530d53b02ba960b160c5656db694d61b22d5fcf3 buster] 
[ FLAGS  DIFF    ] : [broadcom amd64 buster 4f1655a58444e2961e7061d8530d53b02ba960b160c5656db694d61b22d5fcf3 buster ] 
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 The specified blob does not exist.
[  FAIL LOG END  ] [ target/debs/buster/libsaibcm_6.0.0.13-3_amd64.deb ]
make: *** [slave.mk:398: target/debs/buster/libsaibcm_6.0.0.13-3_amd64.deb] Error 1
make: *** Waiting for unfinished jobs....

Thanks!

@gechiang gechiang merged commit 004dc69 into sonic-net:master Mar 15, 2022
@zhengbiqing
Copy link

where is the "BRCM SAI 6.0.0.13-3"?Thanks!

@gechiang
Copy link
Collaborator Author

gechiang commented Mar 27, 2022

@zhengbiqing All BRCM SAI debians are now automatically loaded to the sonic-storage.
You can still figure out its url value by looking at the sai.mk file and sub the necessary branch and release names.

@zhengbiqing
Copy link

This file "https://github.com/Azure/sonic-buildimage/blob/master/platform/broadcom/sai.mk" ?
The brcm sai is "https://sonicstorage.blob.core.windows.net/public/sai/bcmsai/REL_6.0/6.0.0.13-3/libsaibcm_6.0.0.13-3_amd64.deb" ?
This is a lib. Where is the source code?

LIBSAIBCM_VERSION = 6.0.0.13-3
LIBSAIBCM_BRANCH_NAME = REL_6.0
LIBSAIBCM_URL_PREFIX = "https://sonicstorage.blob.core.windows.net/public/sai/bcmsai/$(LIBSAIBCM_BRANCH_NAME)/$(LIBSAIBCM_VERSION)"

BRCM_SAI = libsaibcm_$(LIBSAIBCM_VERSION)_amd64.deb
$(BRCM_SAI)URL = "$(LIBSAIBCM_URL_PREFIX)/$(BRCM_SAI)"
BRCM_SAI_DEV = libsaibcm-dev
$(LIBSAIBCM_VERSION)_amd64.deb
$(eval $(call add_derived_package,$(BRCM_SAI),$(BRCM_SAI_DEV)))
$(BRCM_SAI_DEV)_URL = "$(LIBSAIBCM_URL_PREFIX)/$(BRCM_SAI_DEV)"

@gechiang
Copy link
Collaborator Author

@zhengbiqing My understanding is that BRCM SAI source code are not accessible by the community. If you need access of their source code, please contact BRCM directly.

@zhengbiqing
Copy link

ok. thanks!

@zhengbiqing
Copy link

It's strange only provide lib file but not source code? so what about : https://github.com/Broadcom-Switch/SAI ?

@gechiang
Copy link
Collaborator Author

@zhengbiqing I would suggest that you open an issue with BRCM to see if they would share the SAI code for 6.0 or 6.1 for the Git Repo you mentioned. It looks like BRCM choose to release for some branch but not all. Maybe they have not caught up yet or have other constraints that I am not aware of and will not speculate here. In short, we only release the BRCM SAI debians as part of the sonic-buildimage so that we can provide SONiC images for devices that are BRCM platform based to the SONiC community.
Thanks!

@zhengbiqing
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants