Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Netberg][Barefoot] Added support for Aurora 610 #10579

Merged
merged 17 commits into from
Jun 30, 2022

Conversation

andrewsapronov
Copy link
Contributor

@andrewsapronov andrewsapronov commented Apr 14, 2022

nba610-showplatform-master-220414.txt

Why I did it

Support Intel Tofino based platforms Netberg Aurora 610
ASIC: Intel Tofino BFN-T10-032D-020
Pors: 48x 25G + 8x 100G

How I did it

Added specification to device/netberg directory
Added platform/barefoot/sonic-platform-modules-netberg contains kernel modules, scripts and sonic_platform packages.
Modified the platform/barefoot/one-image.mk and platform/barefoot/rule.mk to include Aurora 610 related ID and files.

How to verify it

Build SONiC

Install the image on the device and verify the related components are installed and shown correctly.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Andrew Sapronov <andrew.sapronov@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 14, 2022

This pull request introduces 32 alerts when merging b441d42 into 0191300 - view on LGTM.com

new alerts:

  • 14 for Unused local variable
  • 7 for Wrong number of arguments in a class instantiation
  • 5 for Variable defined multiple times
  • 3 for Except block handles 'BaseException'
  • 1 for Module imports itself
  • 1 for Syntax error
  • 1 for 'import *' may pollute namespace

Signed-off-by: Andrew Sapronov <andrew.sapronov@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2022

This pull request introduces 14 alerts when merging 6c4a85f into 869ac1d - view on LGTM.com

new alerts:

  • 7 for Wrong number of arguments in a class instantiation
  • 2 for Unused local variable
  • 2 for Variable defined multiple times
  • 1 for Module imports itself
  • 1 for Except block handles 'BaseException'
  • 1 for 'import *' may pollute namespace

Signed-off-by: Andrew Sapronov <andrew.sapronov@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2022

This pull request introduces 7 alerts when merging 892e9b5 into 869ac1d - view on LGTM.com

new alerts:

  • 7 for Wrong number of arguments in a class instantiation

@andrewsapronov
Copy link
Contributor Author

Dear @sujinmkang @prgeor could you please review and merge this PR.

@sujinmkang
Copy link
Collaborator

@andrewsapronov Can you please check if the 7 new lgtm alerts need to be addressed? And also can you please provide the show platform ... cli commands output and pmon daemon status and can you please also share if you have sonic-mgmt platform api test results?

@andrewsapronov
Copy link
Contributor Author

@sujinmkang

Can you please check if the 7 new lgtm alerts need to be addressed?

It's hard to say for me. All of the alerts connected with different numbers of __init__arguments across a broad vendors.

And also can you please provide the show platform ... cli commands output and

Yep, it have already linked in the first message - nba610-showplatform-master-220414.txt

pmon daemon status and can you please also share

Please check - nba610-pmon-daemons-sensors-master-220511.txt

if you have sonic-mgmt platform api test results?

We don't have this yet.

@lgtm-com
Copy link

lgtm-com bot commented May 19, 2022

This pull request introduces 7 alerts when merging cf6bf3e into 937bf09 - view on LGTM.com

new alerts:

  • 7 for Wrong number of arguments in a class instantiation

@andrewsapronov
Copy link
Contributor Author

Dear @sujinmkang do you need something else to approve this PR.

We also check our kernel modules for the recent kernel version update - #10634. They are OK - no changes are needed.

@andrewsapronov andrewsapronov requested a review from a team as a code owner June 10, 2022 02:01
Signed-off-by: Andrew Sapronov <andrew.sapronov@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Jun 19, 2022

This pull request introduces 7 alerts when merging 0fbb1c2 into ed99ce0 - view on LGTM.com

new alerts:

  • 7 for Wrong number of arguments in a class instantiation

@andrewsapronov
Copy link
Contributor Author

@akokhan thanks for the review.

@lguohan, @sujinmkang could you please merge the PR.

@sujinmkang sujinmkang merged commit 7f10b6b into sonic-net:master Jun 30, 2022
@andrewsapronov andrewsapronov deleted the nba610-initial-support branch September 2, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants