[initramfs]: SSD firmware upgrade in initramfs #10748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizhuhuams
reviewed
May 12, 2022
| @@ -114,6 +114,9 @@ migrate_nos_configuration() | |||
| # remove nos-config-part from cmdline | |||
| sed -r -i.bak "s/nos-config-part=[^[:space:]]+//" /host/grub/grub.cfg | |||
|
|
|||
| # remove ssd-upgrader-part from cmdline | |||
There was a problem hiding this comment.
could you please add a comment here to show what exactly the string replacement is?
There was a problem hiding this comment.
In this command, the ssd-upgrader-part option is completely removed from the command line (replaced with an empty string) similar to nos-config-part.
Please let me know if the comment has to updated with 'empty string' in place of 'remove'.
There was a problem hiding this comment.
I see, current comment matches the ode, then I am fine with it.
sujinmkang
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
May 12, 2022
…tion with SONiC partition (#2150) What I did Add new option "-u" in ‘fast-reboot’ script, to add the “ssd-upgrader-part” boot option with SONiC partition and filesystem type. Required by: sonic-net/sonic-buildimage#10748 How I did it Included a new option "-u" in fast-reboot script. If the option '-u' is specified, add "ssd-upgrader-part" with the SONiC partition and filesystem to the boot options to be used with kexec.
sujinmkang
approved these changes
May 12, 2022
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
…tion with SONiC partition (#2150) What I did Add new option "-u" in ‘fast-reboot’ script, to add the “ssd-upgrader-part” boot option with SONiC partition and filesystem type. Required by: sonic-net/sonic-buildimage#10748 How I did it Included a new option "-u" in fast-reboot script. If the option '-u' is specified, add "ssd-upgrader-part" with the SONiC partition and filesystem to the boot options to be used with kexec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To upgrade SSD firmware in initramfs while rebooting from SONiC to SONiC and during NOS to SONiC migration.
How I did it
New option 'ssd-upgrader-part’ is introduced in grub command line, to indicate the partition and its filesystem type in which the SSD firmware updater is present. ‘ssd-upgrader-part’ syntax is
ssd-upgrader-part=<partition>,<filesystem type>. Example: ssd-upgrader-part=/dev/sda8,ext4A new initramfs script ‘ssd-upgrade’ is included in init-premount and it invokes the SSD firmware updater (ssd-fw-upgrade) present in the partition indicated by the boot option 'ssd-upgrader-part'
How to verify it
UT logs: Dell_S6100_SSD_upgrade_in_initramfs_logs.txt
Which release branch to backport (provide reason below if selected)
Description for the changelog
[initramfs]: SSD firmware upgrade in initramfs
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)