[202111] [Mellanox] Fix issue: error message from system-health daemon is observed during system starting #10843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… system starting Error message: "ERR healthd: Failed to read from file /var/run/hw-management/led/led_status_capability" is observed during system starting The system-health daemon will wait for 5 minutes before it starts to run. During this time, the only thing it does is to set the LED even before it starting. However, the corresponding sysfs has not been ready at the time it is being read, which cause the error message. Fix: Defer system-health daemon until hw-management service starts Signed-off-by: Stephen Sun <stephens@nvidia.com>
stephenxs
requested review from
keboliu,
Junchao-Mellanox,
liat-grozovik and
prgeor
stephenxs
added
Bug 🐛
Platform: Mellanox
Request for 202111 Branch
Junchao-Mellanox
approved these changes
May 16, 2022
|
The failure is not caused by the PR. It should be a generic failure. |
liat-grozovik
changed the title
liat-grozovik
approved these changes
May 16, 2022
qiluo-msft
approved these changes
May 17, 2022
5 tasks
|
The build failure is caused by PR #9700 being cherry-picked to 202111 |
Please update and try again. |
liat-grozovik
changed the title
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run azure.sonic-buildimage |
|
/AzurePipelines run azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run azure.sonic-buildimage |
|
/AzurePipelines run azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dprital
removed
the
Request for 202111 Branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Error message: "ERR healthd: Failed to read from file /var/run/hw-management/led/led_status_capability" is observed during system starting
The system-health daemon will wait for 5 minutes before it starts to run.
During this time, the only thing it does is to set the LED even before it starts.
However, the corresponding sysfs has not been ready at the time it is being read, which causes the error message.
Signed-off-by: Stephen Sun stephens@nvidia.com
How I did it
Defer system-health daemon until hw-management service starts
How to verify it
Run regression test
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)