-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mdio IPC client library #11284
Add mdio IPC client library #11284
Conversation
Signed-off-by: Jiahua Wang <jiahua.wang@broadcom.com>
why cannot we put this in the sonic-sairedis repo? we can buiild this library into syncd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not move this to sonic-sairedis repo?
We want to build a separate debian package which can be used by gbsyncd docker. We want to dynamically load the library. |
let's build this client library into the syncd progress, then if we start with gbsyncd, we can decide how to use it. |
Build mdio IPC client library as a debian package and as a .so file has the flexibility. Build the code into syncd process is equivalent to add the debian package as build time dependence and run time dependence of syncd package and add LD flag of -lmdio-ipc-client in the syncd makefile. |
Signed-off-by: Jiahua Wang <jiahua.wang@broadcom.com>
Close the PR for now. Will reopen the PR after design document review. |
We have created the design doc of "SONiC NPU MDIO access support and gbsyncd docker enhancement HLD" PR sonic-net/SONiC#1045 , which explains the reason of creating this mdio IPC client library PR and has reference to this PR. We reopen this PR. |
This PR is replaced by sonic-net/sonic-sairedis#1134 |
Signed-off-by: Jiahua Wang jiahua.wang@broadcom.com
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)