Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mdio IPC client library #11284

Closed
wants to merge 2 commits into from

Conversation

jiahua-wang
Copy link
Contributor

Signed-off-by: Jiahua Wang jiahua.wang@broadcom.com

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Jiahua Wang <jiahua.wang@broadcom.com>
@jiahua-wang jiahua-wang requested a review from lguohan as a code owner June 29, 2022 05:03
@jiahua-wang jiahua-wang mentioned this pull request Jun 29, 2022
7 tasks
@lguohan
Copy link
Collaborator

lguohan commented Jun 30, 2022

why cannot we put this in the sonic-sairedis repo? we can buiild this library into syncd

@lguohan
Copy link
Collaborator

lguohan commented Jun 30, 2022

@jiahua-wang

Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not move this to sonic-sairedis repo?

@jiahua-wang
Copy link
Contributor Author

We want to build a separate debian package which can be used by gbsyncd docker. We want to dynamically load the library.

@lguohan
Copy link
Collaborator

lguohan commented Jun 30, 2022

let's build this client library into the syncd progress, then if we start with gbsyncd, we can decide how to use it.

@jiahua-wang
Copy link
Contributor Author

Build mdio IPC client library as a debian package and as a .so file has the flexibility. Build the code into syncd process is equivalent to add the debian package as build time dependence and run time dependence of syncd package and add LD flag of -lmdio-ipc-client in the syncd makefile.

Signed-off-by: Jiahua Wang <jiahua.wang@broadcom.com>
@jiahua-wang
Copy link
Contributor Author

Close the PR for now. Will reopen the PR after design document review.

@jiahua-wang jiahua-wang closed this Jul 6, 2022
@jiahua-wang
Copy link
Contributor Author

jiahua-wang commented Aug 3, 2022

We have created the design doc of "SONiC NPU MDIO access support and gbsyncd docker enhancement HLD" PR sonic-net/SONiC#1045 , which explains the reason of creating this mdio IPC client library PR and has reference to this PR. We reopen this PR.

@jiahua-wang jiahua-wang reopened this Aug 3, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 3, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@jiahua-wang
Copy link
Contributor Author

This PR is replaced by sonic-net/sonic-sairedis#1134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants