Replace swsssdk with swsscommon in bgpmon.py #11387
Conversation
|
Still under discussion about how to improve hmset method. |
|
This PR related with another PR which will improve hmset performance, but not depends on it: |
src/sonic-bgpcfgd/bgpmon/bgpmon.py
Outdated
| else: | ||
| # Add or Modify case | ||
| self.pipe.hmset(key, value) | ||
| self.pipe.execute() | ||
| self.db.hmset(self.db.STATE_DB, key, value) |
There was a problem hiding this comment.
Will improve this code with pipe
There was a problem hiding this comment.
Will push a update to pipe improve PR, to make code easy here.
There was a problem hiding this comment.
Fixed, now this PR depends on sonic-net/sonic-swss-common#647
We need that PR finish and update submodule first.
There was a problem hiding this comment.
sonic-swss-common PR merged, create another PR to merge submodule: #11470
After that, this PR can pass UT.
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Will delay merge this PR because a resource leak issue in swss-common. |
|
Wait for this PR merge first: #11524 which will fix memory leak issue. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Why I did it
Update bgpmon.py from py-swsssdk to swsscommon
How I did it
Change bgpmon.py to use swsscommon.
How to verify it
Pass all E2E test case
Which release branch to backport (provide reason below if selected)
Description for the changelog
Update bgpmon.py from py-swsssdk to swsscommon
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)