-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PFCWD fix for multi port multi priority scenario for HWSKU Dell Z9332 #11640
Merged
vmittal-msft
merged 2 commits into
sonic-net:master
from
vmittal-msft:vmittal/pfcwd_fix
Aug 22, 2022
Merged
PFCWD fix for multi port multi priority scenario for HWSKU Dell Z9332 #11640
vmittal-msft
merged 2 commits into
sonic-net:master
from
vmittal-msft:vmittal/pfcwd_fix
Aug 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/easycla |
vmittal-msft
force-pushed
the
vmittal/pfcwd_fix
branch
from
August 16, 2022 16:19
3f5d2cf
to
0067c66
Compare
gechiang
approved these changes
Aug 16, 2022
vmittal-msft
force-pushed
the
vmittal/pfcwd_fix
branch
2 times, most recently
from
August 18, 2022 16:27
55dcb96
to
f917c03
Compare
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
force-pushed
the
vmittal/pfcwd_fix
branch
from
August 19, 2022 21:59
f917c03
to
4b901ea
Compare
vmittal-msft
force-pushed
the
vmittal/pfcwd_fix
branch
from
August 22, 2022 16:00
4b901ea
to
7ae0ad5
Compare
gechiang
added
Request for 202012 Branch
Request for 202106 Branch
Request for 202111 Branch
For PRs being requested for 202111 branch
Request for 202205 Branch
labels
Aug 22, 2022
yxieca
pushed a commit
that referenced
this pull request
Aug 26, 2022
…#11640) PFCWD fix for multi port multi priority scenario for HWSKU Dell Z9332
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
Discussion in today's 202012 branch release meeting, add reject tag. |
Fix the rejected tag issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
PFCWD recovery mechanism had issues for multi port multi priority scenario if PFCWD triggers simultaneously.
How I did it
PFCWD recovery mechanism is changed from SONIC based recovery to SAI/SDK using SAI attribute SAI_QUEUE_ATTR_PFC_DLR_INIT.
Order of changes -
How to verify it
Verified the fix on actual HW using ixia as tester.
Which release branch to backport (provide reason below if selected)
Description for the changelog
PFCWD fix for multi port multi priority scenario for HWSKU Dell Z9332
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)