Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFCWD fix for multi port multi priority scenario for HWSKU Dell Z9332 #11640

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

vmittal-msft
Copy link
Contributor

@vmittal-msft vmittal-msft commented Aug 5, 2022

Why I did it

PFCWD recovery mechanism had issues for multi port multi priority scenario if PFCWD triggers simultaneously.

How I did it

PFCWD recovery mechanism is changed from SONIC based recovery to SAI/SDK using SAI attribute SAI_QUEUE_ATTR_PFC_DLR_INIT.

Order of changes -

  1. swss - [sonic-swss] : PFCWD recovery changes using DLR_INIT sonic-swss#2316
  2. SAI change for new method - [BRCM SAI 7.1.7.1] catch up on all pending fix patches for REL_7.0/7.1 #11693
  3. swss submodule update - [sonic-swss submodule] : Updating sonic-swss to pick PFCWD fix  #11690

How to verify it

Verified the fix on actual HW using ixia as tester.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

PFCWD fix for multi port multi priority scenario for HWSKU Dell Z9332

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 5, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: vmittal-msft (973f1622e82e51dffa38e130da6faadc366c48c7, 3f5d2cff874f8540c00e121f36db55b2f9363be9)

@vmittal-msft vmittal-msft requested a review from gechiang August 5, 2022 19:17
@gechiang gechiang marked this pull request as ready for review August 5, 2022 23:11
@gechiang gechiang requested a review from lguohan as a code owner August 5, 2022 23:11
@jarias-lfx
Copy link

/easycla

@vmittal-msft vmittal-msft force-pushed the vmittal/pfcwd_fix branch 2 times, most recently from 55dcb96 to f917c03 Compare August 18, 2022 16:27
@vmittal-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@vmittal-msft
Copy link
Contributor Author

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vmittal-msft vmittal-msft merged commit 2501d1f into sonic-net:master Aug 22, 2022
@vmittal-msft vmittal-msft deleted the vmittal/pfcwd_fix branch August 22, 2022 23:25
yxieca pushed a commit that referenced this pull request Aug 26, 2022
…#11640)

PFCWD fix for multi port multi priority scenario for HWSKU Dell Z9332
@qiluo-msft
Copy link
Collaborator

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

@liuh-80
Copy link
Contributor

liuh-80 commented Feb 2, 2023

Discussion in today's 202012 branch release meeting, add reject tag.

@liuh-80
Copy link
Contributor

liuh-80 commented Apr 26, 2023

Fix the rejected tag issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants