[TACACS] Send remote address in TACACS+ authorization message. #12190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will create E2E test case in sonic-mgmt repo with another PR. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liuh-80
force-pushed
the
dev/liuh/improve-tacacs-address
branch
from
d030fcb to
1c25f25
Compare
qiluo-msft
reviewed
Oct 21, 2022
src/tacacs/nss/patch/0010-Send-remote-address-in-TACACS-authorization-message.patch
Outdated
Show resolved
Hide resolved
qiluo-msft
reviewed
Oct 21, 2022
src/tacacs/nss/patch/0010-Send-remote-address-in-TACACS-authorization-message.patch
Outdated
Show resolved
Hide resolved
qiluo-msft
reviewed
Oct 21, 2022
src/tacacs/nss/patch/0010-Send-remote-address-in-TACACS-authorization-message.patch
Outdated
Show resolved
Hide resolved
qiluo-msft
reviewed
Oct 21, 2022
src/tacacs/nss/patch/0010-Send-remote-address-in-TACACS-authorization-message.patch
Outdated
Show resolved
Hide resolved
qiluo-msft
reviewed
Oct 21, 2022
src/tacacs/nss/patch/0010-Send-remote-address-in-TACACS-authorization-message.patch
Outdated
Show resolved
Hide resolved
qiluo-msft
reviewed
Oct 21, 2022
src/tacacs/nss/patch/0010-Send-remote-address-in-TACACS-authorization-message.patch
Outdated
Show resolved
Hide resolved
qiluo-msft
reviewed
Oct 21, 2022
src/tacacs/nss/patch/0010-Send-remote-address-in-TACACS-authorization-message.patch
Outdated
Show resolved
Hide resolved
qiluo-msft
reviewed
Oct 28, 2022
| +/* | ||
| + * Get environment variable first part by name and delimiters | ||
| + */ | ||
| +int get_environment_variable_first_part(char* dst, socklen_t size, const char* name, const char* delimiters) |
There was a problem hiding this comment.
Fixed, add constants for return values.
qiluo-msft
approved these changes
Oct 31, 2022
yxieca
pushed a commit
that referenced
this pull request
Nov 10, 2022
Send remote address in TACACS+ authorization message. #### Why I did it TACACS+ authorization message not send remote address to server side. #### How I did it Send remote address in TACACS+ authorization message. #### How to verify it Pass all E2E test. Create new test case to validate remote address been send to server side. #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 #### Description for the changelog Send remote address in TACACS+ authorization message. #### Ensure to add label/tag for the feature raised. example - [PR#2174](sonic-net/sonic-utilities#2174) where, Generic Config and Update feature has been labelled as GCU. #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
qiluo-msft
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Apr 6, 2023
…7702) **What I did** Add UT to check TACACS will send remote address to server. **Why I did it** nss-tacplus add a patch to send remote address to server with this PR:sonic-net/sonic-buildimage#12190 To protect the patch, add this UT to check TACACS will send remote address to server. **How I verified it** Pass all UT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send remote address in TACACS+ authorization message.
Why I did it
TACACS+ authorization message not send remote address to server side.
How I did it
Send remote address in TACACS+ authorization message.
How to verify it
Pass all E2E test.
Create new test case to validate remote address been send to server side.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Send remote address in TACACS+ authorization message.
Ensure to add label/tag for the feature raised. example - PR#2174 where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)