Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bgp]: fix for vtysh cli behavior #1227

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Conversation

Mrak-IW
Copy link

@Mrak-IW Mrak-IW commented Dec 11, 2017

- What I did
There are some problems with vtysh:

  1. Text files opens while entering commands
  2. Auto-completion is not working when you call vtysh from a switch itself

- How I did it
I've cherry-picked a commit that fixes it from master branch

- How to verify it
Run:

  1. docker exec -ti bgp vtysh
  2. vtysh
    And compare the behavior. No empty screens with the text "(END)" must appear. Auto-completion must work. Help must appear after you press "?".

- Description for the changelog

vtysh strange behavior fixed

- A picture of a cute animal (not mandatory but encouraged)

 /\_/\
( o.o )
 > ^ <

@lguohan lguohan merged commit fa8edce into sonic-net:201709 Dec 11, 2017
@Mrak-IW Mrak-IW deleted the 201709-vtysh-fix branch December 18, 2017 11:20
abdosi added a commit that referenced this pull request Nov 14, 2020
c0df6355deb8bc3685395f727983a5e9f3b06f61 (HEAD -> 201911, origin/201911) Updates to bgp config and show commands with BGP_INTERNAL_NEIGHBOR table (#1224) (#1237)
d683bb48604220942b9f6bdea90c0ea4ff4f72ef [CLI][show][platform] Added ASIC count in the output. (#1185) (#1227)
4585be10aa8e761ce1091ac4a20e562c2550970c [show] Fix 'show int neigh expected' (#1189)
29e4469d5e6c5058fe20c1ce71790f69b7193e7e [201911][fwutil]: Use logger from sonic-py-common (#1190)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
* [tests]: Specify versions of pip packages

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants