-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YANG] Support syslog rate limit configuration #12488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganglyu
reviewed
Nov 6, 2022
ganglyu
reviewed
Nov 6, 2022
Can you update doc/Configuration.md? |
ganglyu
approved these changes
Nov 7, 2022
mkeda
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work in adding this feature! (especially since it's across so many repositories!).
StormLiangMS
pushed a commit
to StormLiangMS/sonic-buildimage
that referenced
this pull request
Dec 8, 2022
- Why I did it Change YANG model to support syslog rate limit configuration feature - How I did it modified sonic-syslog.yang and sonic-feature.yang to support the new added configuration schema - How to verify it Unit test
StormLiangMS
pushed a commit
that referenced
this pull request
Dec 10, 2022
- Why I did it Change YANG model to support syslog rate limit configuration feature - How I did it modified sonic-syslog.yang and sonic-feature.yang to support the new added configuration schema - How to verify it Unit test
@Junchao-Mellanox PR conflicts with 202211 branch |
StormLiangMS
added
Included in 202211 Branch
and removed
Cherry Pick Conflict_202211
labels
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HLD: sonic-net/SONiC#1049
Why I did it
Change YANG model to support syslog rate limit configuration feature
How I did it
modified sonic-syslog.yang and sonic-feature.yang to support the new added configuration schema
How to verify it
Unit test
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)