Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YANG] Support syslog rate limit configuration #12488

Merged
merged 4 commits into from
Nov 29, 2022

Conversation

Junchao-Mellanox
Copy link
Collaborator

@Junchao-Mellanox Junchao-Mellanox commented Oct 25, 2022

HLD: sonic-net/SONiC#1049

Why I did it

Change YANG model to support syslog rate limit configuration feature

How I did it

modified sonic-syslog.yang and sonic-feature.yang to support the new added configuration schema

How to verify it

Unit test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@ganglyu
Copy link
Contributor

ganglyu commented Nov 6, 2022

Can you update doc/Configuration.md?

@zhangyanzhao zhangyanzhao requested a review from mkeda November 7, 2022 03:51
Copy link
Collaborator

@mkeda mkeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work in adding this feature! (especially since it's across so many repositories!).

@liat-grozovik liat-grozovik merged commit 32eca3f into sonic-net:master Nov 29, 2022
StormLiangMS pushed a commit to StormLiangMS/sonic-buildimage that referenced this pull request Dec 8, 2022
- Why I did it
Change YANG model to support syslog rate limit configuration feature

- How I did it
modified sonic-syslog.yang and sonic-feature.yang to support the new added configuration schema

- How to verify it
Unit test
StormLiangMS pushed a commit that referenced this pull request Dec 10, 2022
- Why I did it
Change YANG model to support syslog rate limit configuration feature

- How I did it
modified sonic-syslog.yang and sonic-feature.yang to support the new added configuration schema

- How to verify it
Unit test
@Junchao-Mellanox Junchao-Mellanox deleted the srl-yang branch January 3, 2023 08:34
@mssonicbld
Copy link
Collaborator

@Junchao-Mellanox PR conflicts with 202211 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants