update notify-keyspace-events in redis.conf #12540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
qiluo-msft
approved these changes
Oct 28, 2022
yxieca
pushed a commit
that referenced
this pull request
Nov 10, 2022
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan arlakshm@microsoft.com Why I did it closes #12343 Today in SONiC the notify-keyspace-events is from DbInterface class when application try do any configdb set. In Chassis the chassis_db may not get any configdb set operations, so there is chance this configuration will never be set. So the chassis_db updates from one line card will not be propogated to other linecards, which are doing a psubscribe to get these event. How I did it update the redis.conf to set notify-keyspace-events AKE so that the notify-keyspace-events are set when the redis instance is started How to verify it Test on chassis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan arlakshm@microsoft.com
Why I did it
closes #12343
Today in SONiC the
notify-keyspace-eventsis from DbInterface class when application try do any configdb set.In Chassis the chassis_db may not get any configdb set operations, so there is chance this configuration will never be set.
So the chassis_db updates from one line card will not be propogated to other linecards, which are doing a
psubscribeto get these event.How I did it
update the redis.conf to set
notify-keyspace-events AKEso that thenotify-keyspace-eventsare set when the redis instance is startedHow to verify it
Test on chassis
Which release branch to backport (provide reason below if selected)
A picture of a cute animal (not mandatory but encouraged)