[Build] Fix the docker image docker-dhcp-relay:latest not found issue #13048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 15, 2022
…sonic-net#13048) Why I did it It is to fix the broadcom build failure, it is caused by the build image docker-dhcp-relay:latest not found. 2022-12-14T00:09:57.5464893Z [ FAIL LOG START ] [ target/docker-dhcp-relay.gz-load ] 2022-12-14T00:09:57.5466036Z Attempting docker image lock for docker-dhcp-relay load 2022-12-14T00:09:57.5467113Z Obtained docker image lock for docker-dhcp-relay load 2022-12-14T00:09:57.5468206Z Loading docker image target/docker-dhcp-relay.gz 2022-12-14T00:09:57.5469361Z Loaded image: docker-dhcp-relay:internal.65852159-11ad82a07a 2022-12-14T00:09:57.5470686Z Tagging docker image docker-dhcp-relay:latest as docker-dhcp-relay-sonic:latest 2022-12-14T00:09:57.5471997Z Error response from daemon: No such image: docker-dhcp-relay:latest 2022-12-14T00:09:57.5473122Z [ FAIL LOG END ] [ target/docker-dhcp-relay.gz-load ] 2022-12-14T00:09:57.5539792Z make: *** [slave.mk:1180: target/docker-dhcp-relay.gz-load] Error 1 2022-12-14T00:09:57.5540958Z make: *** Waiting for unfinished jobs.... The image had been built succeeded 2022-12-13T17:01:59.9046935Z [ finished ] [ target/docker-eventd.gz ] 2022-12-13T17:02:00.4947165Z [ building ] [ target/docker-dhcp-relay.gz ] 2022-12-13T17:02:00.6688627Z /sonic/dockers/docker-dhcp-relay/cli-plugin-tests /sonic 2022-12-13T17:02:41.1123955Z /sonic 2022-12-13T17:07:04.1786069Z [ finished ] [ target/docker-dhcp-relay.gz ] But it was tagged by another value: Obtained docker image lock for docker-dhcp-relay save Tagging docker image docker-dhcp-relay-sonic:latest as docker-dhcp-relay:internal.65852159-11ad82a07a Saving docker image docker-dhcp-relay:internal.65852159-11ad82a07a Released docker image lock for docker-dhcp-relay save Removing docker image docker-dhcp-relay-sonic:latest Untagged: docker-dhcp-relay-sonic:latest target/docker-dhcp-relay.gz File /dpkg_cache/docker-dhcp-relay.gz-2ddfa01a109ca69b7621f1a-450bae36026d9dee62646f2.tgz saved in cache [ CACHE::SAVED ] /dpkg_cache/docker-dhcp-relay.gz-2ddfa01a109ca69b7621f1a-450bae36026d9dee62646f2.tgz How I did it When the feature SONIC_CONFIG_USE_NATIVE_DOCKERD_FOR_BUILD not enabled, always save as the latest tag, not use the specify version. The version is dynamic, it is changed when a new commit checked in, but the image of docker-dhcp-relay is not necessary to change.
|
Cherry-pick PR to 202211: #13071 |
mssonicbld
pushed a commit
that referenced
this pull request
Dec 15, 2022
…#13048) Why I did it It is to fix the broadcom build failure, it is caused by the build image docker-dhcp-relay:latest not found. 2022-12-14T00:09:57.5464893Z [ FAIL LOG START ] [ target/docker-dhcp-relay.gz-load ] 2022-12-14T00:09:57.5466036Z Attempting docker image lock for docker-dhcp-relay load 2022-12-14T00:09:57.5467113Z Obtained docker image lock for docker-dhcp-relay load 2022-12-14T00:09:57.5468206Z Loading docker image target/docker-dhcp-relay.gz 2022-12-14T00:09:57.5469361Z Loaded image: docker-dhcp-relay:internal.65852159-11ad82a07a 2022-12-14T00:09:57.5470686Z Tagging docker image docker-dhcp-relay:latest as docker-dhcp-relay-sonic:latest 2022-12-14T00:09:57.5471997Z Error response from daemon: No such image: docker-dhcp-relay:latest 2022-12-14T00:09:57.5473122Z [ FAIL LOG END ] [ target/docker-dhcp-relay.gz-load ] 2022-12-14T00:09:57.5539792Z make: *** [slave.mk:1180: target/docker-dhcp-relay.gz-load] Error 1 2022-12-14T00:09:57.5540958Z make: *** Waiting for unfinished jobs.... The image had been built succeeded 2022-12-13T17:01:59.9046935Z [ finished ] [ target/docker-eventd.gz ] 2022-12-13T17:02:00.4947165Z [ building ] [ target/docker-dhcp-relay.gz ] 2022-12-13T17:02:00.6688627Z /sonic/dockers/docker-dhcp-relay/cli-plugin-tests /sonic 2022-12-13T17:02:41.1123955Z /sonic 2022-12-13T17:07:04.1786069Z [ finished ] [ target/docker-dhcp-relay.gz ] But it was tagged by another value: Obtained docker image lock for docker-dhcp-relay save Tagging docker image docker-dhcp-relay-sonic:latest as docker-dhcp-relay:internal.65852159-11ad82a07a Saving docker image docker-dhcp-relay:internal.65852159-11ad82a07a Released docker image lock for docker-dhcp-relay save Removing docker image docker-dhcp-relay-sonic:latest Untagged: docker-dhcp-relay-sonic:latest target/docker-dhcp-relay.gz File /dpkg_cache/docker-dhcp-relay.gz-2ddfa01a109ca69b7621f1a-450bae36026d9dee62646f2.tgz saved in cache [ CACHE::SAVED ] /dpkg_cache/docker-dhcp-relay.gz-2ddfa01a109ca69b7621f1a-450bae36026d9dee62646f2.tgz How I did it When the feature SONIC_CONFIG_USE_NATIVE_DOCKERD_FOR_BUILD not enabled, always save as the latest tag, not use the specify version. The version is dynamic, it is changed when a new commit checked in, but the image of docker-dhcp-relay is not necessary to change.
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Mar 2, 2023
…sonic-net#13048) Why I did it It is to fix the broadcom build failure, it is caused by the build image docker-dhcp-relay:latest not found. 2022-12-14T00:09:57.5464893Z [ FAIL LOG START ] [ target/docker-dhcp-relay.gz-load ] 2022-12-14T00:09:57.5466036Z Attempting docker image lock for docker-dhcp-relay load 2022-12-14T00:09:57.5467113Z Obtained docker image lock for docker-dhcp-relay load 2022-12-14T00:09:57.5468206Z Loading docker image target/docker-dhcp-relay.gz 2022-12-14T00:09:57.5469361Z Loaded image: docker-dhcp-relay:internal.65852159-11ad82a07a 2022-12-14T00:09:57.5470686Z Tagging docker image docker-dhcp-relay:latest as docker-dhcp-relay-sonic:latest 2022-12-14T00:09:57.5471997Z Error response from daemon: No such image: docker-dhcp-relay:latest 2022-12-14T00:09:57.5473122Z [ FAIL LOG END ] [ target/docker-dhcp-relay.gz-load ] 2022-12-14T00:09:57.5539792Z make: *** [slave.mk:1180: target/docker-dhcp-relay.gz-load] Error 1 2022-12-14T00:09:57.5540958Z make: *** Waiting for unfinished jobs.... The image had been built succeeded 2022-12-13T17:01:59.9046935Z [ finished ] [ target/docker-eventd.gz ] 2022-12-13T17:02:00.4947165Z [ building ] [ target/docker-dhcp-relay.gz ] 2022-12-13T17:02:00.6688627Z /sonic/dockers/docker-dhcp-relay/cli-plugin-tests /sonic 2022-12-13T17:02:41.1123955Z /sonic 2022-12-13T17:07:04.1786069Z [ finished ] [ target/docker-dhcp-relay.gz ] But it was tagged by another value: Obtained docker image lock for docker-dhcp-relay save Tagging docker image docker-dhcp-relay-sonic:latest as docker-dhcp-relay:internal.65852159-11ad82a07a Saving docker image docker-dhcp-relay:internal.65852159-11ad82a07a Released docker image lock for docker-dhcp-relay save Removing docker image docker-dhcp-relay-sonic:latest Untagged: docker-dhcp-relay-sonic:latest target/docker-dhcp-relay.gz File /dpkg_cache/docker-dhcp-relay.gz-2ddfa01a109ca69b7621f1a-450bae36026d9dee62646f2.tgz saved in cache [ CACHE::SAVED ] /dpkg_cache/docker-dhcp-relay.gz-2ddfa01a109ca69b7621f1a-450bae36026d9dee62646f2.tgz How I did it When the feature SONIC_CONFIG_USE_NATIVE_DOCKERD_FOR_BUILD not enabled, always save as the latest tag, not use the specify version. The version is dynamic, it is changed when a new commit checked in, but the image of docker-dhcp-relay is not necessary to change.
|
Cherry-pick PR to 202205: #14052 |
mssonicbld
pushed a commit
that referenced
this pull request
Mar 2, 2023
…#13048) Why I did it It is to fix the broadcom build failure, it is caused by the build image docker-dhcp-relay:latest not found. 2022-12-14T00:09:57.5464893Z [ FAIL LOG START ] [ target/docker-dhcp-relay.gz-load ] 2022-12-14T00:09:57.5466036Z Attempting docker image lock for docker-dhcp-relay load 2022-12-14T00:09:57.5467113Z Obtained docker image lock for docker-dhcp-relay load 2022-12-14T00:09:57.5468206Z Loading docker image target/docker-dhcp-relay.gz 2022-12-14T00:09:57.5469361Z Loaded image: docker-dhcp-relay:internal.65852159-11ad82a07a 2022-12-14T00:09:57.5470686Z Tagging docker image docker-dhcp-relay:latest as docker-dhcp-relay-sonic:latest 2022-12-14T00:09:57.5471997Z Error response from daemon: No such image: docker-dhcp-relay:latest 2022-12-14T00:09:57.5473122Z [ FAIL LOG END ] [ target/docker-dhcp-relay.gz-load ] 2022-12-14T00:09:57.5539792Z make: *** [slave.mk:1180: target/docker-dhcp-relay.gz-load] Error 1 2022-12-14T00:09:57.5540958Z make: *** Waiting for unfinished jobs.... The image had been built succeeded 2022-12-13T17:01:59.9046935Z [ finished ] [ target/docker-eventd.gz ] 2022-12-13T17:02:00.4947165Z [ building ] [ target/docker-dhcp-relay.gz ] 2022-12-13T17:02:00.6688627Z /sonic/dockers/docker-dhcp-relay/cli-plugin-tests /sonic 2022-12-13T17:02:41.1123955Z /sonic 2022-12-13T17:07:04.1786069Z [ finished ] [ target/docker-dhcp-relay.gz ] But it was tagged by another value: Obtained docker image lock for docker-dhcp-relay save Tagging docker image docker-dhcp-relay-sonic:latest as docker-dhcp-relay:internal.65852159-11ad82a07a Saving docker image docker-dhcp-relay:internal.65852159-11ad82a07a Released docker image lock for docker-dhcp-relay save Removing docker image docker-dhcp-relay-sonic:latest Untagged: docker-dhcp-relay-sonic:latest target/docker-dhcp-relay.gz File /dpkg_cache/docker-dhcp-relay.gz-2ddfa01a109ca69b7621f1a-450bae36026d9dee62646f2.tgz saved in cache [ CACHE::SAVED ] /dpkg_cache/docker-dhcp-relay.gz-2ddfa01a109ca69b7621f1a-450bae36026d9dee62646f2.tgz How I did it When the feature SONIC_CONFIG_USE_NATIVE_DOCKERD_FOR_BUILD not enabled, always save as the latest tag, not use the specify version. The version is dynamic, it is changed when a new commit checked in, but the image of docker-dhcp-relay is not necessary to change.
mssonicbld
added
Included in 202205 Branch
and removed
Approved for 202205 Branch
Created PR to 202205 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
It is to fix the broadcom build failure, it is caused by the build image docker-dhcp-relay:latest not found.
The image had been built succeeded
But it was tagged by another value:
How I did it
When the feature SONIC_CONFIG_USE_NATIVE_DOCKERD_FOR_BUILD not enabled, always save as the latest tag, not use the specify version.
The version is dynamic, it is changed when a new commit checked in, but the image of docker-dhcp-relay is not necessary to change.
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)