[Micas/Platform]platform support M2-W6510 #15888

philo-micas · 2023-07-18T05:20:16Z

Why I did it

Add new platform m2-w6510(Trident 3)
ASIC Vendor: Broadcom
Switch ASIC: Trident 3
Port Config: 48x25G+8x100G

How I did it

Provide device and platform related files.

How to verify it

show platform fan
show platform ssdhealth
show platform psustatus
show platform summary
show platform syseeprom
show platform temperature
show interface status

Work item tracking

Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: philo <philo@micasnetworks.com>

xumia · 2023-07-18T23:00:09Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2023-07-18T23:00:22Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: philo <philo@micasnetworks.com>

jarias-lfx · 2023-07-19T18:56:31Z

/easycla

philo-micas · 2023-08-03T06:13:40Z

@lguohan Hi guohan, help assign a code review to forward this PR, thanks!

philo-micas · 2023-08-18T09:37:50Z

@prgeor Help review the code, thanks!

Signed-off-by: philo <philo@micasnetworks.com>

prgeor · 2023-09-05T17:29:57Z

platform/broadcom/sonic-platform-modules-micas/common/modules/wb_optoe.c

@philo-micas why not use existing optoe driver in sonic-linux-kernel repo?

@prgeor Wb_ OPTPE. c is revised based on the kernel's OPTOE. c to fix the issue of crashes caused by switching between different OPTPE types : sonic-net/sonic-linux-kernel#317

@philo-micas please raise a fix in the sonic-linux-kernel repo so that it benefits the community

@prgeor OK, will raise in month, if no other review, help forward this pr, thanks!

prgeor · 2023-09-05T18:09:30Z

device/micas/x86_64-micas_m2-w6510-48v8c-r0/plugins/ssd_util.py

@philo-micas why not use https://github.com/sonic-net/sonic-platform-common/blob/master/sonic_platform_base/sonic_ssd/ssd_generic.py

@prgeor Some SSD model cannot be read according to the generic, so we have added our own implementation under the SSD specification plugin

@philo-micas please raise a community fix in https://github.com/sonic-net/sonic-platform-common/blob/master/sonic_platform_base/sonic_ssd/ssd_generic.py

@prgeor OK, will raise in month, if no other review, help forward this pr, thanks!

prgeor · 2023-09-05T18:10:37Z

platform/broadcom/sonic-platform-modules-micas/common/modules/linux-5.10/wb_i2c_mux_pca954x.c

@philo-micas pretty much duplicate of https://github.com/torvalds/linux/blob/master/drivers/i2c/muxes/i2c-mux-pca954x.c. So, why not use the same from sonic-linux-kernel repo?

@prgeor wb_i2c_mux_pca954x.c is revised based on the i2c-mux-pca954x.c, adding 9548 reset function to improve I2C reliability

@philo-micas please upstream your fix to linux kernel community.

@prgeor OK, will raise in month, if no other review, help forward this pr, thanks!

philo-micas · 2023-09-06T02:41:47Z

@prgeor thanks for reviewing, and have replied some comments, and the reason for keeping other kernel modules show as below:

wb_at24.c is revised based on the at24.c, adding AT24_FLAG_IRUGO flag for EEPROM's flag to enable none root users' read access, solving the problem of none root users throwing exceptions when executing the show command
wb_i2c_algo_bit.c is revised based on the i2c-algo-bit.c, adding I2C level detection and 9 clock functions to improve I2C reliability
wb_i2c_i801.c is revised based on the i2c-i801.c, adding controller reset and 9 clock functions to improve I2C reliability

prgeor · 2023-09-06T16:38:46Z

@lguohan for additional review

lguohan · 2023-09-23T08:10:49Z

for all duplicated drivers in the kernel, please create patch in sonic-linux-kernel, meanwhile do the upstream efforts. we can see whether some of the patch make sense or not. for example, the change to "adding AT24_FLAG_IRUGO flag for EEPROM's flag to enable none root users' read access" does not make sense to me.

lguohan · 2023-09-23T08:15:54Z

i also see binary files, we do not accept platform binary files

Signed-off-by: philo <philo@micasnetworks.com>

philo-micas · 2023-10-05T23:34:57Z

@lguohan Hi Guohan, the kernel patch is only used by us for now and under Micas' platform folders. We will put forward the problems we encountered and some of our suggestions in sonic-linux-kernel community, and cooperate the community to push the solution of the problem.

Also, we follow the community rules and have deleted all binary files except custom_led.bin because the solution provided by BRCM requires users to write custom_led.c and compile it to generate the custom_led.bin file, same file exists on other vendors' platforms.

philo-micas · 2024-01-09T09:47:41Z

@lguohan Have done kernel 6.1 adaptation, as we have reviewed and fixed all reviewed comments month ago, (leave one semgrep error as 'defusedxml' not installed in sonic; test failed due to the test bed connect fail, compiling is fine), help push this pr forward again, thanks.

philo-micas · 2024-01-11T09:36:40Z

report_6510_0110.zip
Kernel 6.1.38 adaption
Platform test report from sonic-mgmt.

philo-micas · 2024-01-11T09:44:34Z

report_6510_0110.zip Kernel 6.1.38 adaption Platform test report from sonic-mgmt.

@lguohan Hi guohan, test report has been submitted, please help to push forward this pr. Thanks.

Signed-off-by: philo <philo@micasnetworks.com>

…c-buildimage into master-M2-W6510

StephenSJCA · 2024-03-06T03:12:17Z

report_6510_0110.zip Kernel 6.1.38 adaption Platform test report from sonic-mgmt.

@lguohan Hi guohan, test report has been submitted, please help to push forward this pr. Thanks.

@lguohan Hi Guohan, please take the time to push forward this PR, it is urgent for us, many thanks!

Signed-off-by: philo <philo@micasnetworks.com>

philo-micas · 2024-03-15T11:13:59Z

Leave one semgrep error as 'defusedxml' was not installed in sonic.

zhangyanzhao · 2024-03-26T18:48:13Z

i also see binary files, we do not accept platform binary files

Is this issue addressed? @philo-micas

philo-micas · 2024-03-27T00:38:05Z

i also see binary files, we do not accept platform binary files

Is this issue addressed? @philo-micas

@zhangyanzhao Yes, we have addressed and fixed it in this PR and and other PRs.

lguohan · 2024-04-30T22:47:43Z

platform/broadcom/sonic-platform-modules-micas/common/modules/linux-5.10/wb_tps53622.c

@@ -0,0 +1,265 @@
+// SPDX-License-Identifier: GPL-2.0-or-later


master image is already kernel 6.1 iirc, why still try to do linux 5.10?

OK, fixed it.

prgeor · 2024-05-02T01:37:42Z

platform/broadcom/sonic-platform-modules-micas/common/modules/linux-5.10/wb_at24.c

+AT24_CHIP_DATA(at24_data_24c01, 1024 / 8, 0);
+AT24_CHIP_DATA(at24_data_24cs01, 16,
+	AT24_FLAG_SERIAL | AT24_FLAG_READONLY);
+AT24_CHIP_DATA(at24_data_24c02, 2048 / 8, AT24_FLAG_IRUGO);


@philo-micas can we use udev rule instead? Ref:-https://martin-jones.com/2016/08/12/making-beaglebone-black-serial-number-available-to-user-applications/

DRIVER=="bone-capemgr", RUN+="/bin/chown root:i2c /sys$env{DEVPATH}/baseboard/serial-number" SUBSYSTEM=="i2c", DEVPATH=="*0-0050", RUN+="/bin/chown root:i2c /sys$env{DEVPATH}/eeprom", RUN+="/bin/chmod 0640 /sys$env{DEVPATH}/eeprom"

Signed-off-by: philo <philo@micasnetworks.com>

…modules/driver/Makefile Signed-off-by: philo <philo@micasnetworks.com>

Signed-off-by: philo <philo@micasnetworks.com>

philo-micas · 2024-05-17T01:10:48Z

@lguohan Hi guohan, help push forward this, most comments have been addressed, and help rerun the test case for one of the failing test case, thanks.

lguohan · 2024-05-31T07:29:51Z

too many duplicated linux kernel modules in this PR. All drivers under this folder (platform/broadcom/sonic-platform-modules-micas/common/modules/linux/) are duplicated from linux kernel. This is cause lots of maintenance issues.

Why I did it Add new platform m2-w6510(Trident 3) ASIC Vendor: Broadcom Switch ASIC: Trident 3 Port Config: 48x25G+8x100G How I did it Provide device and platform related files. How to verify it show platform fan show platform ssdhealth show platform psustatus show platform summary show platform syseeprom show platform temperature show interface status

platform support M2-W6510

6a713bc

Signed-off-by: philo <philo@micasnetworks.com>

philo-micas requested a review from lguohan as a code owner July 18, 2023 05:20

fix compile error

c91fe11

Signed-off-by: philo <philo@micasnetworks.com>

philo-micas added 2 commits July 19, 2023 08:35

fix compile error

4ce78fc

Signed-off-by: philo <philo@micasnetworks.com>

fix code stytle for review

6af64de

Signed-off-by: philo <philo@micasnetworks.com>

yxieca requested a review from prgeor August 14, 2023 23:47

Merge branch 'master' into master-M2-W6510

450f4a7

philo-micas mentioned this pull request Aug 21, 2023

[Micas/Platform]platform support M2-W6510-32C #16094

Closed

11 tasks

fix semgrep

3715251

Signed-off-by: philo <philo@micasnetworks.com>

philo-micas mentioned this pull request Aug 25, 2023

[Micas/Platform]platform support M2-W6910-64C #16144

Open

11 tasks

philo-micas added 2 commits September 5, 2023 10:35

Merge branch 'master' into master-M2-W6510

65d078b

reserve semgrep fix since it will casue show env command fail

927ee90

prgeor reviewed Sep 5, 2023

View reviewed changes

lguohan added the device label Sep 23, 2023

lguohan added Not Ready to Merge 🕑 Platform: Micas labels Sep 23, 2023

philo-micas added 4 commits September 27, 2023 15:54

Modifying device and platform files

55fc7b7

Signed-off-by: philo <philo@micasnetworks.com>

del binary files

8e3c182

Signed-off-by: philo <philo@micasnetworks.com>

update device and platfrom files

4022b24

Signed-off-by: philo <philo@micasnetworks.com>

update permitted_list

a797bc8

Signed-off-by: philo <philo@micasnetworks.com>

Update rules.mk

11a1aee

philo-micas added 2 commits February 23, 2024 10:49

update device files

d0d13cc

Signed-off-by: philo <philo@micasnetworks.com>

Merge branch 'master-M2-W6510' of https://github.com/philo-micas/soni…

16bbcdf

…c-buildimage into master-M2-W6510

triggle rebuld

05fa49f

Signed-off-by: philo <philo@micasnetworks.com>

trigger rebuild

bbe949b

philo-micas added 2 commits April 24, 2024 08:58

Update restful_api.py

31f08e1

Update restful_api.py

20fe35e

lguohan reviewed Apr 30, 2024

View reviewed changes

prgeor reviewed May 2, 2024

View reviewed changes

philo-micas added 2 commits May 10, 2024 15:05

Revised according to PR comments

7101e12

Signed-off-by: philo <philo@micasnetworks.com>

update platform/broadcom/sonic-platform-modules-micas/m2-w6510-48v8c/…

759d665

…modules/driver/Makefile Signed-off-by: philo <philo@micasnetworks.com>

philo-micas mentioned this pull request May 11, 2024

[Micas Common]Add Micas platform common files #18941

Open

11 tasks

philo-micas and others added 4 commits May 11, 2024 17:46

fix review comments about kernel driver

db247e2

Signed-off-by: philo <philo@micasnetworks.com>

fix strncpy semgrep

3b3579a

Signed-off-by: philo <philo@micasnetworks.com>

fix-xml-to-lxml

550654c

Signed-off-by: philo <philo@micasnetworks.com>

trigger rebuild

177d9e5

philo-micas added 2 commits May 19, 2024 07:05

trigger rebuild

1195cdc

Merge branch 'sonic-net:master' into master-M2-W6510

094c8c3

lguohan merged commit ebac764 into sonic-net:master May 31, 2024
20 checks passed

philo-micas mentioned this pull request Jul 17, 2024

[Micas]platform M2-W6510 standardization by using native Linux kernel drivers #19600

Open

		@@ -0,0 +1,265 @@
		// SPDX-License-Identifier: GPL-2.0-or-later

[Micas/Platform]platform support M2-W6510 #15888

[Micas/Platform]platform support M2-W6510 #15888

Conversation

philo-micas commented Jul 18, 2023 • edited Loading

Why I did it

How I did it

How to verify it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

xumia commented Jul 18, 2023

azure-pipelines bot commented Jul 18, 2023

jarias-lfx commented Jul 19, 2023

philo-micas commented Aug 3, 2023

philo-micas commented Aug 18, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

philo-micas Sep 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

philo-micas commented Sep 6, 2023

prgeor commented Sep 6, 2023

lguohan commented Sep 23, 2023

lguohan commented Sep 23, 2023

philo-micas commented Oct 5, 2023

philo-micas commented Jan 9, 2024

philo-micas commented Jan 11, 2024

philo-micas commented Jan 11, 2024

StephenSJCA commented Mar 6, 2024

philo-micas commented Mar 15, 2024 • edited Loading

zhangyanzhao commented Mar 26, 2024

philo-micas commented Mar 27, 2024 • edited Loading

Choose a reason for hiding this comment

philo-micas May 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

philo-micas May 6, 2024 • edited Loading

Choose a reason for hiding this comment

philo-micas commented May 17, 2024

lguohan commented May 31, 2024

philo-micas commented Jul 18, 2023 •

edited

Loading

philo-micas Sep 7, 2023 •

edited

Loading

philo-micas commented Mar 15, 2024 •

edited

Loading

philo-micas commented Mar 27, 2024 •

edited

Loading

philo-micas May 6, 2024 •

edited

Loading

philo-micas May 6, 2024 •

edited

Loading