Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[device/dell] Add z9100 pfc T0 support #1708

Merged
merged 1 commit into from
May 21, 2018
Merged

[device/dell] Add z9100 pfc T0 support #1708

merged 1 commit into from
May 21, 2018

Conversation

vharish02
Copy link
Contributor

This commit adds new code to support z9100 PFC T0 support with
broadcom recommended MMU settings for PFC feature.

Unit tested the setting by loading sonic-broadcom.bin and checking
the hardware for the values from the JSON file. The T0 configs supports
fan-out of 100G ports on Z9100. Added new config.bcm for fanout of 100G
ports and tested the fanout by sending traffic using bcmcmd, new file
will be copied to /etc/bcm/th-z9100-8x100-48x50G.config.bcm. This file
has to be packaged with libsaibcm library. Will send the file to Ying.

Signed-off-by: Harish Venkatraman Harish_Venkatraman@dell.com

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@vharish02
Copy link
Contributor Author

@yxieca Can you please review

prsunny
prsunny reviewed May 15, 2018
View reviewed changes
device/dell/x86_64-dell_z9100_c2538-r0/Force10-Z9100-T0/port_config.ini Outdated
Ethernet112 5,6,7,8 hundredGigE1/29 29 100000
Ethernet116 1,2,3,4 hundredGigE1/30 30 100000
Ethernet120 13,14 FiftyGigE1/31/1 31 50000
Ethernet122 15,16 FiftyGigE1/31/1 31 50000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

31/2 ??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you followed the porting guide, particularly testing on your target device and making sure that all ports come up online.

prsunny
prsunny reviewed May 15, 2018
View reviewed changes
device/dell/x86_64-dell_z9100_c2538-r0/Force10-Z9100-T0/port_config.ini Outdated
Ethernet18 67,68 FiftyGigE1/5/2 5 50000
Ethernet20 69,70 FiftyGigE1/6/1 6 50000
Ethernet22 71,72 FiftyGigE1/6/2 6 50000
Ethernet24 73,74,75,76 hundredGigE1/7 7 100000
Copy link
Contributor

@prsunny prsunny May 15, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion to use one convention, either all alias name starts with lowercase or all with uppercase. Also, in my understanding, if name says fiftyGig it must follow same naming as hundredGig.. like fiftyGigE1/1, 1/2, 1/3..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure will change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the convention like what was done in FTOS where it is fiftyGiGE1/1/1 and 1/1/2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point is at the first letter, please use lower case as you suggested.

device/dell/x86_64-dell_z9100_c2538-r0/Force10-Z9100-T0/sai.profile Outdated
@@ -0,0 +1 @@
SAI_INIT_CONFIG_FILE=/etc/bcm/th-z9100-8x100-48x50G.config.bcm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an observation, rest of the config files specify G as in 8x100G

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok will change accordingly

yxieca
yxieca requested changes May 15, 2018
View reviewed changes
Copy link
Contributor

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please add your bcm.config file to this folder.
  2. Change sail.profile according to the porting guide.
  3. Test on the target dut and make sure that all ports come up online.

[device/dell] Add z9100 pfc T0 support
741a1b3 
This commit adds new code to support z9100 PFC T0 support with
broadcom recommended MMU settings for PFC feature.

Unit tested the setting by loading sonic-broadcom.bin and checking
the hardware for the values from the JSON file. The T0 configs supports
fan-out of 100G ports on Z9100. Added new config.bcm for fanout of 100G
ports and tested the fanout by sending traffic using bcmcmd, new config.bcm
file will be copied to /usr/share/sonic/hwsku/th-z9100-8x100-48x50G.config.bcm.
The sai.profile file is updated to point to hwsku directory.

Signed-off-by: Harish Venkatraman <Harish_Venkatraman@dell.com>
@vharish02 vharish02 force-pushed the z9100-pfc-t0-support branch from 1dbbd09 to 741a1b3 Compare May 21, 2018 17:38
@yxieca yxieca merged commit 5feb363 into sonic-net:master May 21, 2018
daall added a commit to daall/sonic-buildimage that referenced this pull request Apr 29, 2021
@daall
[202012][swss/swss-common/utilities/kernel] Update submodule
78dd1ab 
sonic-swss:
- [Monitor Vlan] Fix a typo in hostif (sonic-net#1722)
- Update pool sizes during initialization from timer only (sonic-net#1708)
- [SflowMgr] SamplingRate Update by Speed Change Added (sonic-net#1721)

sonic-swss-common:
- [swss-common] Add MUX Metrics Table (sonic-net#482)
- [azp] Purge swss before installing the newly built deb package (sonic-net#472)

sonic-utilities:
- disk_check: Check & mount RO as RW using tmpfs (sonic-net#1569)
- No more IP validation as it is more likely a URL (sonic-net#1555)
- Stop PMON docker before cold and soft reboots (sonic-net#1514)
- Add soft-reboot reboot type (sonic-net#1453)
- [acl] Use a list instead of a comma-separated string for ACL port list (sonic-net#1519)
- sonic-installer: fix py3 issues in bootloader.aboot (sonic-net#1553)
- Fix unsupported fs.squashfs extraction in sonic-installer (sonic-net#1366)
- [show][config] cli support for firmware upgrade on Y-Cable (sonic-net#1528) (sonic-net#1558)

sonic-linux-kernel:
- [Mellanox] backport kernel patches for hw-management 7.0100.2303 (sonic-net#211)

Signed-off-by: Danny Allen <daall@microsoft.com>
@daall daall mentioned this pull request Apr 29, 2021
Merged
4 tasks
lguohan pushed a commit that referenced this pull request May 4, 2021
@daall
[202012][swss/swss-common/utilities/kernel] Update submodule (#7487)
6060da3 
* [202012][swss/swss-common/utilities/kernel] Update submodule

sonic-swss:
- [Monitor Vlan] Fix a typo in hostif (#1722)
- Update pool sizes during initialization from timer only (#1708)
- [SflowMgr] SamplingRate Update by Speed Change Added (#1721)

sonic-swss-common:
- [swss-common] Add MUX Metrics Table (#482)
- [azp] Purge swss before installing the newly built deb package (#472)

sonic-utilities:
- disk_check: Check & mount RO as RW using tmpfs (#1569)
- No more IP validation as it is more likely a URL (#1555)
- Stop PMON docker before cold and soft reboots (#1514)
- Add soft-reboot reboot type (#1453)
- [acl] Use a list instead of a comma-separated string for ACL port list (#1519)
- sonic-installer: fix py3 issues in bootloader.aboot (#1553)
- Fix unsupported fs.squashfs extraction in sonic-installer (#1366)
- [show][config] cli support for firmware upgrade on Y-Cable (#1528) (#1558)

sonic-linux-kernel:
- [Mellanox] backport kernel patches for hw-management 7.0100.2303 (#211)

Signed-off-by: Danny Allen <daall@microsoft.com>

* Update utilities w/ build fix
@shlomibitton shlomibitton mentioned this pull request May 13, 2021
Merged
vdahiya12 added a commit to vdahiya12/sonic-buildimage that referenced this pull request Jul 28, 2021
@vdahiya12
[sonic-utilities] submodule update
ba2876c 
this PR updates the following commits
c2ac2d2 [show] fix show muxcable metrics <port> for sorted output (sonic-net#1731)
4422911 [fwutil]: Update command reference doc: per component FW update.
(sonic-net#1708)
b83d2bf [minigraph][port_config] Use imported config.main and add
conditional patch (sonic-net#1724)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@vdahiya12 vdahiya12 mentioned this pull request Jul 28, 2021
Merged
5 tasks
lguohan pushed a commit that referenced this pull request Jul 31, 2021
@vdahiya12
[sonic-utilities] submodule update (#8279)
2b5d3ab 
this PR updates the following commits

c2ac2d2 [show] fix show muxcable metrics <port> for sorted output (#1731)
4422911 [fwutil]: Update command reference doc: per component FW update.
(#1708)
b83d2bf [minigraph][port_config] Use imported config.main and add
conditional patch (#1724)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@vdahiya12
[sonic-utilities] submodule update (sonic-net#8279)
0d42bb8 
this PR updates the following commits

c2ac2d2 [show] fix show muxcable metrics <port> for sorted output (sonic-net#1731)
4422911 [fwutil]: Update command reference doc: per component FW update.
(sonic-net#1708)
b83d2bf [minigraph][port_config] Use imported config.main and add
conditional patch (sonic-net#1724)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@stephenxs
Update pool sizes during initialization from timer only (sonic-net#1708)
8ef950c 
- What I did
This is a supplement of sonic-net#1685. In that PR, most of the cases in which the buffer pool updated during initialization have been avoided but there are still some rare cases not covered. Eg., it will try to recalculate the pool size because the lossless PSs are removed if one port is admin down.

- Why I did it
Make sure that the the buffer pools will be updated only once during initialization.

- How I verified it
Run regression and manual test

Signed-off-by: Stephen Sun <stephens@nvidia.com>
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
@nazariig
[fwutil]: Update command reference doc: per component FW update. (son…
4422911 
…ic-net#1708)

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
What I did
Updated command reference to match fwutil v.2.0.0.0
How I did it
Updated command reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny prsunny left review comments

@yxieca yxieca yxieca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vharish02 @prsunny @yxieca