[action] [PR:17630] [image_config]: Update DHCP rate-limit for mgmt TOR devices #17655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t#17630) * [image_config]: Update DHCP rate-limit for mgmt TOR devices Change DHCP rate limit(queue4,group3) in SONiC copp configuration to 300 PPS for mgmt TORs while keeping the rate limit at 100 PPS for other topologies. Why I did it: Some mgmt TORs based on Marvell ASIC do not support 100 PPS CIR, so that led to these devices silently dropping DHCP packets. Microsoft ADO: **25820076** How to verify it: Send DHCP broadcast packets to an M0 DUT and verify that they are trapped to CPU at 300 PPS. On non-mgmt devices, the packets should be trapped at CIR of 100 PPS. Also ran sonic-mgmt dhcp_relay test and confirmed that it passes. Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
12 tasks
|
Original PR: #17630 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change DHCP rate limit(queue4,group3) in SONiC copp configuration to 300 PPS
for mgmt TORs while keeping the rate limit at 100 PPS for other topologies.
Why I did it
Some mgmt TORs based on Marvell ASIC do not support 100 PPS CIR, so that led
to these devices silently dropping DHCP packets.
Work item tracking
How I did it
Updated copp_cfg.j2 to set queue4_group3 rate-limit to 300 PPS for mgmt TOR devices and 100 PPS for other device
topologies.
How to verify it
Send DHCP broadcast packets to an M0 DUT and verify that they are trapped to
CPU at 300 PPS. On non-mgmt devices, the packets should be trapped at CIR of
100 PPS. Also ran sonic-mgmt dhcp_relay test and confirmed that it passes.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)