Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:18925] [Mellanox] Improve FW upgrade: add locking mechanism. (#18925) #19294

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

mssonicbld
Copy link
Collaborator

User implications:
On cold/warm/fast reboot if there is a syncd service start ongoing, the target procedure will stay blocked until the original call is done. This may delay the action in time.

  • Why I did it
    Improve the upgrade fw script avoiding errors in the logs when cold reboot is executed during service restart
    Work item tracking

  • How I did it
    Added locking mechanism for Mellanox FW upgrade

  • How to verify it
    Run cold reboot after DUT first install

Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com

User implications:
On cold/warm/fast reboot if there is a syncd service start ongoing, the target procedure will stay blocked until the original call is done. This may delay the action in time.

- Why I did it
Improve the upgrade fw script avoiding errors in the logs when cold reboot is executed during service restart
Work item tracking

- How I did it
Added locking mechanism for Mellanox FW upgrade

- How to verify it
Run cold reboot after DUT first install

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@mssonicbld
Copy link
Collaborator Author

Original PR: #18925

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator Author

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit 23400f8 into sonic-net:202405 Jun 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants