Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marvell][Nokia-M0] Set custom create switch timeout #19928

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

pavannaregundi
Copy link
Contributor

@pavannaregundi pavannaregundi commented Aug 16, 2024

Why I did it

Migrating Nokia-M0 armhf platform from SONiC 202311 to master and 202405 branch, resulted in syncd create_switch timeout.
It is analyzed to see that SAI SDK code remains the same and time consume by SAI SDK during init when some(snmp mgmt-framework lldp gnmi dhcp_relay radv teamd pmon bgp) of the docker in sonic are disabled is same as running on 202311(with same environment).

Some of the other observations are:

  • Switch create time varies from 50sec to 85 sec randomly depending on CPU load.
  • Running bullseye based 5.10 sonic kernel yielded same result on latest master.
  • Running docker ps -a in 202405 shows all dockers attempting to start, while in 202311 it delays most dockers.
  • No single docker seems to have a significant impact.
Work item tracking
  • Microsoft ADO (number only):

How I did it

Added changes to support custom create_switch timeout value to orchagent from hwsku.
Orchagent changes are captured in PR sonic-net/sonic-swss#3258

How to verify it

Verified by running SONIC PTF run on Nokia-M0.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202405

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Change enables orchagent.sh to pass create switch timeout value
to orchagent as a command line arument from hwsku.

Signed-off-by: Pavan Naregundi <pnaregundi@marvell.com>
Signed-off-by: Pavan Naregundi <pnaregundi@marvell.com>
@pavannaregundi
Copy link
Contributor Author

@Blueve @Pavan-Nokia Please check.

@pavannaregundi
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liushilongbuaa
Copy link
Contributor

/azpw ms_checker

@pavannaregundi
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yxieca yxieca merged commit b62d018 into sonic-net:master Oct 11, 2024
23 checks passed
@Blueve
Copy link
Contributor

Blueve commented Oct 11, 2024

ADO: 29208990

@bingwang-ms
Copy link
Contributor

MSADO 29208990

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Oct 11, 2024
* [Marvell] Pass create switch timeout variable to orchagent

Change enables orchagent.sh to pass create switch timeout value
to orchagent as a command line arument from hwsku.

Signed-off-by: Pavan Naregundi <pnaregundi@marvell.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #20477

mssonicbld pushed a commit that referenced this pull request Oct 11, 2024
* [Marvell] Pass create switch timeout variable to orchagent

Change enables orchagent.sh to pass create switch timeout value
to orchagent as a command line arument from hwsku.

Signed-off-by: Pavan Naregundi <pnaregundi@marvell.com>
sschlafman pushed a commit to sschlafman/sonic-buildimage that referenced this pull request Oct 15, 2024
* [Marvell] Pass create switch timeout variable to orchagent

Change enables orchagent.sh to pass create switch timeout value
to orchagent as a command line arument from hwsku.

Signed-off-by: Pavan Naregundi <pnaregundi@marvell.com>
aidan-gallagher pushed a commit to aidan-gallagher/sonic-buildimage that referenced this pull request Nov 16, 2024
* [Marvell] Pass create switch timeout variable to orchagent

Change enables orchagent.sh to pass create switch timeout value
to orchagent as a command line arument from hwsku.

Signed-off-by: Pavan Naregundi <pnaregundi@marvell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants