Add YANG Model and Configuration Support for Memory Statistics #20354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arham-Nasir <arqamnasir719@gmail.com>
|
Hi @qiluo-msft , @prgeor , and @FengPan-Frank , Could you please help review the HLD and the linked code PRs for our feature? Thank you! |
|
could you pls change meanwhile? |
Signed-off-by: Arham-Nasir <arqamnasir719@gmail.com>
@FengPan-Frank , I updated the sonic-buildimage/src/sonic-yang-models/doc/Configuration.md file to include the Memory Statistics section. Thank you for your feedback! |
|
/azpw run Azure.sonic-buildimage |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Arham-Nasir <arqamnasir719@gmail.com>
|
@qiluo-msft @xincunli-sonic @zbud-msft . Please help review the feature. |
ridahanif96
approved these changes
Nov 5, 2024
|
@qiluo-msft @xincunli-sonic pls help review this feature |
qiluo-msft
approved these changes
Dec 3, 2024
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
…-net#20354) This PR introduces a new YANG model for configuring memory statistics in SONiC, along with necessary updates to the configuration database and test cases. The following changes have been made: YANG Model: Created a new YANG module sonic-memory-statistics.yang for managing memory statistics configuration parameters, including: enabled: Boolean flag to enable or disable memory statistics collection. sampling_interval: Configurable time interval for sampling memory statistics. retention_period: Configurable retention period for memory statistics data. Configuration Database: Updated sample_config_db.json to include default values for the memory statistics configuration, ensuring seamless integration with the existing configuration management. Test Cases: Added comprehensive test cases in memory_statistics.json to validate the configuration parameters, including valid configurations and error scenarios for invalid sampling intervals and retention periods. These changes aim to enhance the monitoring capabilities of SONiC by providing a structured way to configure memory statistics, thereby improving overall system performance and resource management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new YANG model for configuring memory statistics in SONiC, along with necessary updates to the configuration database and test cases. The following changes have been made:
YANG Model:
sonic-memory-statistics.yangfor managing memory statistics configuration parameters, including:enabled: Boolean flag to enable or disable memory statistics collection.sampling_interval: Configurable time interval for sampling memory statistics.retention_period: Configurable retention period for memory statistics data.Configuration Database:
sample_config_db.jsonto include default values for the memory statistics configuration, ensuring seamless integration with the existing configuration management.Test Cases:
memory_statistics.jsonto validate the configuration parameters, including valid configurations and error scenarios for invalid sampling intervals and retention periods.These changes aim to enhance the monitoring capabilities of SONiC by providing a structured way to configure memory statistics, thereby improving overall system performance and resource management.