-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include DPU module to sonic-chassis-module.yang #20445
base: master
Are you sure you want to change the base?
Conversation
enabled building of dhcp_server
docker-pmon-supervisord
selectively include the DHCP_SERVER and moved the common code to platform_utils
e31cff2
to
5a88429
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rameshraghupathy why PR is in draft?
@rameshraghupathy can you fix the build error |
|
@prgeor It was passing before. May be some new conflict has arrived? Synced again and let us see. |
rules/docker-platform-monitor.mk
Outdated
@@ -54,6 +54,7 @@ $(DOCKER_PLATFORM_MONITOR)_CONTAINER_NAME = pmon | |||
$(DOCKER_PLATFORM_MONITOR)_RUN_OPT += --privileged -t | |||
$(DOCKER_PLATFORM_MONITOR)_RUN_OPT += -v /etc/sonic:/etc/sonic:ro | |||
$(DOCKER_PLATFORM_MONITOR)_RUN_OPT += -v /etc/timezone:/etc/timezone:ro | |||
$(DOCKER_PLATFORM_MONITOR)_RUN_OPT += -v /host/reboot-cause:/host/reboot-cause:rw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rameshraghupathy why PMON need access to reboot-cause dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rameshraghupathy this change is not related to YANG model change. Can you remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b033ef6
to
a07bd1d
Compare
@rameshraghupathy could you check build errors? |
216075d
to
395b8a0
Compare
dd83b58
to
6d06265
Compare
{ | ||
"name": "DPU1", | ||
"admin_status": "down" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicated configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one nit.
It currently allows user to administratively bring down a line-card or fabric-card | ||
CHASSIS_MODULE table holds the list and configuration of linecard, DPU modules and fabric modules in a SONiC chassis. | ||
It currently allows user to administratively bring down a line-card or DPU or fabric-card | ||
A smartswitch chassis will not have LINE-CARD and FABRIC-CARD. It will only have DPUs as shown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits: use the code formatted LINE-CARD
instead of plain LINE-CARD so readers know you are referring to a json field. Same for the others.
Why I did it
The modules have been extended to DPUx to support SmartSwitch. As part of the SmartSwitch development module "DPUx" needs to be supported in every section of the code that referring to modules.
Work item tracking
How I did it
Updated "src/sonic-yang-models/yang-models/sonic-chassis-module.yang" file with "|DPU[0-9]" dpu module name.
How to verify it
Which release branch to backport (provide reason below if selected)
No need to brackport
Tested branch (Please provide the tested image version)
master
Description for the changelog
Added DPU modules to sonic-chassis-module.yang
Link to config_db schema for YANG module changes
Updated https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
A picture of a cute animal (not mandatory but encouraged)