[system-health] delay system-health service start #20771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
|
@bingwang-ms, @vaibhavhd , could you please help to review? |
|
@saiarcot895 Could you please help review? Thanks |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
saiarcot895
reviewed
Nov 20, 2024
| @@ -5,6 +5,9 @@ | |||
| System health monitor daemon for SONiC | |||
| """ | |||
|
|
|||
| from swsscommon.swsscommon import RestartWaiter | |||
| RestartWaiter.waitAdvancedBootDone() | |||
There was a problem hiding this comment.
Does this call need to be at this point? Can it be in the main method?
There was a problem hiding this comment.
@saiarcot895 no, we prefer to wait before application starts importing python modules since importing some can be pretty CPU expensive as some run code at import time.
saiarcot895
approved these changes
Nov 26, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 2, 2024
Why I did it To improve boot time and stabilize boot time as well as fast-reboot downtime consistency. How I did it Delay system-health daemon till boot is finished, same as other daemons. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
|
Cherry-pick PR to 202405: #20995 |
mssonicbld
pushed a commit
that referenced
this pull request
Dec 4, 2024
Why I did it To improve boot time and stabilize boot time as well as fast-reboot downtime consistency. How I did it Delay system-health daemon till boot is finished, same as other daemons. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
Why I did it To improve boot time and stabilize boot time as well as fast-reboot downtime consistency. How I did it Delay system-health daemon till boot is finished, same as other daemons. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To improve boot time and stabilize boot time as well as fast-reboot downtime consistency.
Work item tracking
How I did it
Delay system-health daemon till boot is finished, same as other daemons.
How to verify it
Boot the system, verify system-health service starts with a delay, execute command:
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)