Add SRv6 support in Bgpcfgd #21156
Merged
Add SRv6 support in Bgpcfgd #21156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BYGX-wcr
requested review from
abdosi,
dgsudharsan,
eddieruan-alibaba,
lguohan and
rlhui
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Commenter does not have sufficient privileges for PR 21156 in repo sonic-net/sonic-buildimage |
|
/azp rerun |
|
Command 'rerun' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
|
@abdosi , can you please trigger the run pipeline for me? |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abdosi
approved these changes
Jan 10, 2025
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Yakiv-Huryk
reviewed
Jan 11, 2025
| @@ -75,6 +76,9 @@ def do_work(): | |||
| RouteMapMgr(common_objs, "APPL_DB", swsscommon.APP_BGP_PROFILE_TABLE_NAME), | |||
| # Device Global Manager | |||
| DeviceGlobalCfgMgr(common_objs, "CONFIG_DB", swsscommon.CFG_BGP_DEVICE_GLOBAL_TABLE_NAME), | |||
| # SRv6 Manager | |||
| SRv6Mgr(common_objs, "CONFIG_DB", "SRV6_MY_SIDS"), | |||
There was a problem hiding this comment.
nitpick: you can use the "swsscommon." table names added in the sonic-net/sonic-swss-common#962
There was a problem hiding this comment.
Thanks. Yet, I am not sure when that swss-common feature will be cherry-picked into 202412. Let's keep using the literals by now. I can raise a PR to use the reference later.
ahsalam
approved these changes
Jan 13, 2025
dgsudharsan
pushed a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Jan 15, 2025
Why I did it There is a motivation to add capabilities in SONiC that allows static configuration of SRv6 network. Work item tracking Microsoft ADO (number only): 30251795 How I did it I added a SRv6 manager in Bgpcfgd that subscribes to SRV6_MY_LOCATORS and SRV6_MY_SIDS in CONFIG_DB and programs the changes to FRR's configuration. Note: this change depends on the availability and implementation details of the following FRR patch FRR SRv6 Static SID CLI How to verify it - Run unit tests - Build an image that contains this change and the relevant FRR CLI support. - Test the Image on a virtual device or physical device
11 tasks
|
Cherry-pick PR to msft-202412: |
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
Why I did it There is a motivation to add capabilities in SONiC that allows static configuration of SRv6 network. Work item tracking Microsoft ADO (number only): 30251795 How I did it I added a SRv6 manager in Bgpcfgd that subscribes to SRV6_MY_LOCATORS and SRV6_MY_SIDS in CONFIG_DB and programs the changes to FRR's configuration. Note: this change depends on the availability and implementation details of the following FRR patch FRR SRv6 Static SID CLI How to verify it - Run unit tests - Build an image that contains this change and the relevant FRR CLI support. - Test the Image on a virtual device or physical device
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
There is a motivation to add capabilities in SONiC that allows static configuration of SRv6 network.
Work item tracking
How I did it
I added a SRv6 manager in Bgpcfgd that subscribes to SRV6_MY_LOCATORS and SRV6_MY_SIDS in CONFIG_DB and programs the changes to FRR's configuration.
Note: this change depends on the availability and implementation details of the following FRR patch FRR SRv6 Static SID CLI
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
SRv6 static config HLD
A picture of a cute animal (not mandatory but encouraged)