Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set swssconfig.sh startsecs=0 for quick exiting #2181

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

qiluo-msft
Copy link
Collaborator

@qiluo-msft qiluo-msft commented Oct 23, 2018

The default startsecs is 1 second. However, swssconfig.sh will quickly
exit with expected exit code 0 during warm starting. This case should
not be treated as a failure

Before this fix

Oct 22 23:58:45.495722 sonic INFO swss.sh[1688]: 2018-10-22 23:58:45,495 INFO exited: swssconfig (exit status 0; not expected)
Oct 22 23:58:45.496639 sonic INFO swss.sh[1688]: 2018-10-22 23:58:45,496 INFO gave up: swssconfig entered FATAL state, too many start retries too quickly

After this fix

Oct 23 00:15:52.954857 sonic INFO swss#supervisord 2018-10-23 00:14:50,068 INFO exited: swssconfig (exit status 0; expected)

ref: http://supervisord.org/configuration.html

The default startsecs is 1 second. However, swssconfig.sh will quickly
exit with expected exit code 0 during warm starting. This case should
not be treated as a failure
@qiluo-msft qiluo-msft merged commit 709cd5a into sonic-net:master Oct 23, 2018
@qiluo-msft qiluo-msft deleted the qiluo/fixstartsecs branch October 23, 2018 06:40
stepanblyschak added a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 27, 2022
```
3d3c89b fix for non-coherent cmis modules (sonic-net#2163)
2054680 [subinterface] Fix route add command to accept subinterface as dev (sonic-net#2180)
5383e92 [subinterface]Avoid removing the subinterface when last configured ip is removed (sonic-net#2181)
f5af780 [GCU] Handling type1 lists (sonic-net#2171)
4516179 [yang] extend ConfigMgmt constructor to pass YANG options (sonic-net#2118)
2f53bd4 [dump] implement ACL modules (sonic-net#2153)
494dd62 show commands for SYSTEM READY (sonic-net#1851)
4fc09b1 [GCU] Handling non-compliant leaf-list with string values (sonic-net#2174)
675c7b6 Add sonic-delayed.target to Application Extension .timer file generator (sonic-net#2176)
c587933 [portconfig] Allow to configure interface mtu for physical ports only
9881f3e Broadcast Unknown-multicast and Unknown-unicast Storm-control  (sonic-net#928)
88286cb sonic-utils: initial support for link-training (sonic-net#2071)
29503ab [portchannel] Added ACL/PBH binding checks to the port before getting added to portchannel (sonic-net#2151)
ac89489 Modify override testcase to cover PORT admin_status (sonic-net#2165)
d7953d2 [GCU] Validate peer_group_range ip_range are correct (sonic-net#2145)
aa81b97 [auto-ts] add memory check (sonic-net#2116)
b370290 support new interface types CR8/SR8/KR8/LR8 which are brougnt by SAI V.1.10.2 (sonic-net#2167)
87fc0a4 [scripts/fast-reboot] Add option to include ssd-upgrader-part boot option with SONiC partition (sonic-net#2150)
90abc07 [config reload] Fix invalid rstrip. (sonic-net#2157)
fac1769 Accept 0 for queue and dscp (sonic-net#2162)
```

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Jun 16, 2022
linkmgrrd:
* d6518dd 2022-06-14 | Fix IP header checksum in handleSendSwitchCommand (sonic-net#88) (HEAD -> 202205, github/202205) [Jing Zhang]

swss:
* 4430445 2022-06-03 | Add port counter sanity check (sonic-net#2300) (HEAD -> 202205, github/202205) [Junhua Zhai]
* 01b017c 2022-05-28 | [counter] Support gearbox counters (sonic-net#2218) [Junhua Zhai]

utilities:
* ce96543 2022-05-26 | [subinterface]Avoid removing the subinterface when last configured ip is removed (sonic-net#2181) (HEAD -> 202205, github/202205) [Sudharsan Dhamal Gopalarathnam]
* ed97c6f 2022-05-26 | [subinterface] Fix route add command to accept subinterface as dev (sonic-net#2180) [Sudharsan Dhamal Gopalarathnam]
* 53ff644 2022-06-09 | [gendump] Add Support to dump BCM-DNX commands (sonic-net#1813) [saksarav-nokia]
* 0e31790 2022-06-15 | [config][muxcable] fix minor config DB logic issue (sonic-net#2210) [vdahiya12]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca added a commit that referenced this pull request Jun 16, 2022
linkmgrrd:
* d6518dd 2022-06-14 | Fix IP header checksum in handleSendSwitchCommand (#88) (HEAD -> 202205, github/202205) [Jing Zhang]

swss:
* 4430445 2022-06-03 | Add port counter sanity check (#2300) (HEAD -> 202205, github/202205) [Junhua Zhai]
* 01b017c 2022-05-28 | [counter] Support gearbox counters (#2218) [Junhua Zhai]

utilities:
* ce96543 2022-05-26 | [subinterface]Avoid removing the subinterface when last configured ip is removed (#2181) (HEAD -> 202205, github/202205) [Sudharsan Dhamal Gopalarathnam]
* ed97c6f 2022-05-26 | [subinterface] Fix route add command to accept subinterface as dev (#2180) [Sudharsan Dhamal Gopalarathnam]
* 53ff644 2022-06-09 | [gendump] Add Support to dump BCM-DNX commands (#1813) [saksarav-nokia]
* 0e31790 2022-06-15 | [config][muxcable] fix minor config DB logic issue (#2210) [vdahiya12]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
wen587 pushed a commit that referenced this pull request Jun 22, 2022
05c79ef Fix header for the output table following 'show ipv6 interface' command (#2219)
fc5633f increase coverage to 80% (#2214)
c0dffba [config][muxcable] fix minor config DB logic issue (#2210)
a50eca0 [generic-config-updater] Add NTP validator  (#2212)
a3d1345 [gendump] Add Support to dump BCM-DNX commands (#1813)
bb185d5 [yang] remove mistakenly added parameter for 'get_module_name' (#2193)
2cccf26 [counters] skip showing counters that are not enabled (#2199)
ff05bc8 [config][muxcable] Add support for displaying soc_ipv4 and cable_type in config/show muxcable commands (#2189)
3197f39 Add check to not allow deleting PO if its member of vlan. (#2141)
2513da1 [dump] Optimized dump state cli and modified tests to not use common data  (#2175)
9e310e5 Fix sonic-installer and 'show version' command crash when database docker not running issue. (#2183)
4ad70b9 [sonic-installer] use host docker startup arguments when running dockerd in chroot  (#2179)
3d3c89b fix for non-coherent cmis modules (#2163)
2054680 [subinterface] Fix route add command to accept subinterface as dev (#2180)
5383e92 [subinterface]Avoid removing the subinterface when last configured ip is removed (#2181)
f5af780 [GCU] Handling type1 lists (#2171)
4516179 [yang] extend ConfigMgmt constructor to pass YANG options (#2118)
2f53bd4 [dump] implement ACL modules (#2153)
494dd62 show commands for SYSTEM READY (#1851)
4fc09b1 [GCU] Handling non-compliant leaf-list with string values (#2174)
675c7b6 Add sonic-delayed.target to Application Extension .timer file generator (#2176)
c587933 [portconfig] Allow to configure interface mtu for physical ports only
9881f3e Broadcast Unknown-multicast and Unknown-unicast Storm-control  (#928)
88286cb sonic-utils: initial support for link-training (#2071)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants