[build image] copy init_interfaces to interfaces #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
init_interfaces meant to be sonic init interfaces configuration file. However, it needs to be copied to the right file name to take effect. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
lguohan
approved these changes
Nov 26, 2018
|
What about the current interfaces.j2 file? Any conflicts? |
|
Not ready to merge yet. Though this change saved 60+ second in boot up time. The updategraph service didn't turn on dhcp on eth0 after boot up when minigraph is missing. This behavior might cause some unexpected behavior. This change should only be merged after updategraph service can turn on dhcp client on eth0. |
|
Never mind. It is my next change needs matching update graph service change. not this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ying Xie ying.xie@microsoft.com
- What I did
init_interfaces meant to be sonic init interfaces configuration file.
However, it needs to be copied to the right file name to take effect.