[platform/broadcom] Silverstone update platform i2c driver

[pphuchar]

- What I did
Update the Silverstone i2c driver to work with new FPGA i2c firmware version 1.5.
The new FPGA firmware improves i2c stability. This feature is mandatory for the current Silverstone machine which shipped with FPGA firmware version 1.5 by default.

- How I did it

• Make changes in the platform driver module and init script.
• Update the sfputil plugins.

- How to verify it
Test with Silverstone FPGA firmware version 1.5 and see the sfputil command works normally.

- Description for the changelog

• Silverstone update platform i2c driver based on opencore.

- A picture of a cute animal (not mandatory but encouraged)

[lguohan]

retest vsimage please

[lguohan]

retest vs please

[pphuchar]

Regression test with show interface

NOTE: Due to limitation, QSFP-DD module only plug at first two ports, others are QSFP28

root@sonic:/home/admin# show int st
  Interface                            Lanes    Speed    MTU     Alias    Vlan    Oper    Admin                                             Type    Asym PFC
-----------  -------------------------------  -------  -----  --------  ------  ------  -------  -----------------------------------------------  ----------
  Ethernet0          33,34,35,36,37,38,39,40     400G   9100   QSFPDD1  routed      up       up  QSFP-DD Double Density 8X Pluggable Transceiver         N/A
  Ethernet4          41,42,43,44,45,46,47,48     400G   9100   QSFPDD2  routed      up       up  QSFP-DD Double Density 8X Pluggable Transceiver         N/A
  Ethernet8          49,50,51,52,53,54,55,56     400G   9100   QSFPDD3  routed    down       up                                  QSFP28 or later         N/A
 Ethernet12          57,58,59,60,61,62,63,64     400G   9100   QSFPDD4  routed    down       up                                  QSFP28 or later         N/A
 Ethernet16          65,66,67,68,69,70,71,72     400G   9100   QSFPDD5  routed    down       up                                  QSFP28 or later         N/A
 Ethernet20          73,74,75,76,77,78,79,80     400G   9100   QSFPDD6  routed    down       up                                  QSFP28 or later         N/A
 Ethernet24          81,82,83,84,85,86,87,88     400G   9100   QSFPDD7  routed    down       up                                  QSFP28 or later         N/A
 Ethernet28          89,90,91,92,93,94,95,96     400G   9100   QSFPDD8  routed    down       up                                  QSFP28 or later         N/A
 Ethernet32                  1,2,3,4,5,6,7,8     400G   9100   QSFPDD9  routed    down       up                                  QSFP28 or later         N/A
 Ethernet36           9,10,11,12,13,14,15,16     400G   9100  QSFPDD10  routed    down       up                                  QSFP28 or later         N/A
 Ethernet40          17,18,19,20,21,22,23,24     400G   9100  QSFPDD11  routed    down       up                                  QSFP28 or later         N/A
 Ethernet44          25,26,27,28,29,30,31,32     400G   9100  QSFPDD12  routed    down       up                                  QSFP28 or later         N/A
 Ethernet48     97,98,99,100,101,102,103,104     400G   9100  QSFPDD13  routed    down       up                                  QSFP28 or later         N/A
 Ethernet52  105,106,107,108,109,110,111,112     400G   9100  QSFPDD14  routed    down       up                                  QSFP28 or later         N/A
 Ethernet56  113,114,115,116,117,118,119,120     400G   9100  QSFPDD15  routed    down       up                                  QSFP28 or later         N/A
 Ethernet60  121,122,123,124,125,126,127,128     400G   9100  QSFPDD16  routed    down       up                                  QSFP28 or later         N/A
 Ethernet64  129,130,131,132,133,134,135,136     400G   9100  QSFPDD17  routed    down       up                                  QSFP28 or later         N/A
 Ethernet68  137,138,139,140,141,142,143,144     400G   9100  QSFPDD18  routed    down       up                                  QSFP28 or later         N/A
 Ethernet72  145,146,147,148,149,150,151,152     400G   9100  QSFPDD19  routed    down       up                                  QSFP28 or later         N/A
 Ethernet76  153,154,155,156,157,158,159,160     400G   9100  QSFPDD20  routed    down       up                                  QSFP28 or later         N/A
 Ethernet80  225,226,227,228,229,230,231,232     400G   9100  QSFPDD21  routed    down       up                                  QSFP28 or later         N/A
 Ethernet84  233,234,235,236,237,238,239,240     400G   9100  QSFPDD22  routed    down       up                                  QSFP28 or later         N/A
 Ethernet88  241,242,243,244,245,246,247,248     400G   9100  QSFPDD23  routed    down       up                                  QSFP28 or later         N/A
 Ethernet92  249,250,251,252,253,254,255,256     400G   9100  QSFPDD24  routed    down       up                                  QSFP28 or later         N/A
 Ethernet96  161,162,163,164,165,166,167,168     400G   9100  QSFPDD25  routed    down       up                                  QSFP28 or later         N/A
Ethernet100  169,170,171,172,173,174,175,176     400G   9100  QSFPDD26  routed    down       up                                  QSFP28 or later         N/A
Ethernet104  177,178,179,180,181,182,183,184     400G   9100  QSFPDD27  routed    down       up                                  QSFP28 or later         N/A
Ethernet108  185,186,187,188,189,190,191,192     400G   9100  QSFPDD28  routed    down       up                                  QSFP28 or later         N/A
Ethernet112  193,194,195,196,197,198,199,200     400G   9100  QSFPDD29  routed    down       up                                  QSFP28 or later         N/A
Ethernet116  201,202,203,204,205,206,207,208     400G   9100  QSFPDD30  routed    down       up                                  QSFP28 or later         N/A
Ethernet120  209,210,211,212,213,214,215,216     400G   9100  QSFPDD31  routed    down       up                                  QSFP28 or later         N/A
Ethernet124  217,218,219,220,221,222,223,224     400G   9100  QSFPDD32  routed    down       up                                  QSFP28 or later         N/A
root@sonic:/home/admin# show int tra pre
Port         Presence
-----------  ----------
Ethernet0    Present
Ethernet4    Present
Ethernet8    Present
Ethernet12   Present
Ethernet16   Present
Ethernet20   Present
Ethernet24   Present
Ethernet28   Present
Ethernet32   Present
Ethernet36   Present
Ethernet40   Present
Ethernet44   Present
Ethernet48   Present
Ethernet52   Present
Ethernet56   Present
Ethernet60   Present
Ethernet64   Present
Ethernet68   Present
Ethernet72   Present
Ethernet76   Present
Ethernet80   Present
Ethernet84   Present
Ethernet88   Present
Ethernet92   Present
Ethernet96   Present
Ethernet100  Present
Ethernet104  Present
Ethernet108  Present
Ethernet112  Present
Ethernet116  Present
Ethernet120  Present
Ethernet124  Present
root@sonic:/home/admin# show int tra eeprom Ethernet0
Ethernet0: SFP EEPROM detected
        Connector: N/A
        Encoding: N/A
        Extended Identifier: N/A
        Extended RateSelect Compliance: N/A
        Identifier: QSFP-DD Double Density 8X Pluggable Transceiver
        N/A: N/A
        Nominal Bit Rate(100Mbs): N/A
        Specification compliance: 
        Vendor Date Code(YYYY-MM-DD Lot): N/A
        Vendor Name: LEONI
        Vendor OUI: N/A
        Vendor PN: L45593-K900-A115
        Vendor Rev: 02
        Vendor SN: LEO1851G462

root@sonic:/home/admin# show int tra eeprom Ethernet4
Ethernet4: SFP EEPROM detected
        Connector: N/A
        Encoding: N/A
        Extended Identifier: N/A
        Extended RateSelect Compliance: N/A
        Identifier: QSFP-DD Double Density 8X Pluggable Transceiver
        N/A: N/A
        Nominal Bit Rate(100Mbs): N/A
        Specification compliance: 
        Vendor Date Code(YYYY-MM-DD Lot): N/A
        Vendor Name: LEONI
        Vendor OUI: N/A
        Vendor PN: L45593-K900-A115
        Vendor Rev: 02
        Vendor SN: LEO1844G14E

root@sonic:/home/admin# show int tra eeprom Ethernet4 -d
Ethernet4: SFP EEPROM detected
        Connector: N/A
        Encoding: N/A
        Extended Identifier: N/A
        Extended RateSelect Compliance: N/A
        Identifier: QSFP-DD Double Density 8X Pluggable Transceiver
        N/A: N/A
        Nominal Bit Rate(100Mbs): N/A
        Specification compliance: 
        Vendor Date Code(YYYY-MM-DD Lot): N/A
        Vendor Name: LEONI
        Vendor OUI: N/A
        Vendor PN: L45593-K900-A115
        Vendor Rev: 02
        Vendor SN: LEO1844G14E
        ChannelMonitorValues: 
        ChannelThresholdValues: 
        ModuleMonitorValues: 
        ModuleThresholdValues: 

root@sonic:/home/admin# show int tra eeprom Ethernet0 -d
Ethernet0: SFP EEPROM detected
        Connector: N/A
        Encoding: N/A
        Extended Identifier: N/A
        Extended RateSelect Compliance: N/A
        Identifier: QSFP-DD Double Density 8X Pluggable Transceiver
        N/A: N/A
        Nominal Bit Rate(100Mbs): N/A
        Specification compliance: 
        Vendor Date Code(YYYY-MM-DD Lot): N/A
        Vendor Name: LEONI
        Vendor OUI: N/A
        Vendor PN: L45593-K900-A115
        Vendor Rev: 02
        Vendor SN: LEO1851G462
        ChannelMonitorValues: 
        ChannelThresholdValues: 
        ModuleMonitorValues: 
        ModuleThresholdValues: 

root@sonic:/home/admin# exit
admin@sonic:~$ 

[lguohan]

retest vs please

[lguohan]

retest vs please

[lguohan]

https://elixir.bootlin.com/linux/v4.1/source/drivers/i2c/busses/i2c-ocores.c

why not use linux kernel source code?

[pphuchar]

Hello,

The reason we keep it as a separate are:

1. The original i2c-ocores in sonic kernel version 4.9.x is not support polling mode. We use the codes based on kernel 5.1 to support this feature.
2. We add a workaround to fix read error on some SFP loopback module.

If only the first reason, we can backport the feature from kernel 5.1 to current sonic-linux-kernel, but combined with the 2nd reason, we decide to maintain the codes as a platform-specific.

[lguohan]

why do we need this workaround? We add a workaround to fix read error on some SFP loopback module.

[pphuchar]

In some SFP module case.
When reading EEPROM, the i2c core detects the arbitration lost(AL) error and stop the i2c transfer. The AL randomly occurs on the device.

To make the device readable, the limited retry is added to the ocore FSM. When AL detected, it restarts the i2c transfer again until retry used up.

[lguohan]

this seems like a generic fix, can you patch the kernel in sonic-linux-kernel?

[pphuchar]

Yes, I will create a PR to patch i2c-ocores.c in sonic-linux-kernel to support polling mode.
For the workaround, we found that it was a bug in the FPGA firmware and fixed with new firmware, so it will not include in this patch.

[lguohan]

thanks. I will review your sonic-linux-kernel patch and merge this pr after kernel patch has been fixed.

[pphuchar]

The kernel patch has been introduced here sonic-net/sonic-linux-kernel#135.

[pphuchar]

The driver is updated to use kernel's i2c-ocores module.

[lguohan]

kernel existing code.

[pphuchar]

As we keep the own maintain version of i2c-ocores, this file is needed for module compile.

[pphuchar]

This will be removed after the sonic-net/sonic-linux-kernel#135 is merged.

[pphuchar]

The driver is updated to use kernel's i2c-ocores module.

[mudsut4ke]

retest broadcom please

[pphuchar]

I have rebased the changes onto the master and apply 2 changes

• Advance the sonic-linux-kernel pointer to includes i2c-ocores patch.
• Update the platform driver to use i2c-ocores from sonic kernel.