[interface-config] Fix a loopback addr config bug #437

taoyl-ms · 2017-03-25T00:56:03Z

Fix a bug introduced in PR #430 that addresses on lo are not configured correctly.

It turns out that service networking restart won’t reconfigure lo.
What we need is service networking restart AND ifdown lo && ifup lo.

Fix a bug introduced in PR 430 that addresses on lo are not configured correctly.

stcheng · 2017-03-25T01:11:43Z

there are --exclude=lo in /etc/init.d/networking file. seems to be some reasons. not sure why.

- [config/main.py]Fixed - added a validation such that delete portchannel or portchannel members only when it is configured (#277) (#445) - Revert "[config/main.py]Fixed - added a validation such that delete portchannel or portchannel members only when it is configured (#277) (#445)" (#452) - [intfutil] add Asymmetric PFC status to 'show interface status' (#437) Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>

Submodule src/sonic-sairedis 8182916..483c89e: > Notify OA about exception and process only restart query events (sonic-net#437) Submodule src/sonic-swss 91171b6..d22b2de: > Allow ACL entry creation without ACL counter (sonic-net#818) Signed-off-by: Ying Xie <ying.xie@microsoft.com>

…#2728) Submodule src/sonic-sairedis 8182916..483c89e: > Notify OA about exception and process only restart query events (#437) Submodule src/sonic-swss 91171b6..d22b2de: > Allow ACL entry creation without ACL counter (#818) Signed-off-by: Ying Xie <ying.xie@microsoft.com>

…sonic-net#2728) Submodule src/sonic-sairedis 8182916..483c89e: > Notify OA about exception and process only restart query events (sonic-net#437) Submodule src/sonic-swss 91171b6..d22b2de: > Allow ACL entry creation without ACL counter (sonic-net#818) Signed-off-by: Ying Xie <ying.xie@microsoft.com>

…2755) sonic-sairedis: e8cb879 Make object list deterministic when iterating (#438) 5486f97 Ignore ACL_COUNTER bytes and packets during comparison logic (#443) b138ff9 Notify OA about exception and process only restart query events (#437) 0974a43 Set MTU value on created tap device for virtual switch (#436) e2f50e8 Increase eth buffer size to 16k for virtual switch (#435) 79fb388 [bfn] Ged rid of ld_preload. Link against libsai only (#429) 2e47b78 Remove MAC alignment WA for Mellanox platforms. (#430) e1354fe Add pre match to comparison logic and unittests (#423) 18a5ebb Drop FDB notifications if they contain invalid OIDs (#428) sonic-swss-common: 8af58ad sonic-swss-common: Add vxlan macros to schema (#269) 76837bf Make class Select support batch read from selectables (#270) 4cf643e Add multiple fields hdel support (#267) a710529 Update PFC_WD table name in CONFIG_DB (#266) 3c452c1 Update README.md (#268) sonic-swss: e329dbd Survive pfc watchdog storm action across warm-reboot (#794) sonic-utilities: 6ee0aea (HEAD, origin/master, origin/HEAD) [config]: Change the order of interface commands (#504) 5ae30d2 [show vlan brief] Support 'alias' interface naming mode (#497) bafebf9 Update neighbor advertiser (#498) fa90083 [clear/main.py]: clear ndp command. (#450) 65f69e4 [show interface neighbor expected] Support 'alias' interface naming mode (#495) aae39e7 updated show ipv6 interface for alias mode (#493) 170fed9 [warm-reboot] initialize warm reboot state table before warm rebooting (#492) 06cd99f Allow config shutdown and startup operations on valid PortChannel interface names (#474) 98cdebb [show ip interface] Add support for 'alias' interface naming mode (#486) 5f1de81 [show] Add serial numbers/uptime/hwinfo to 'show version' output (#488) e78a866 [route_check] Move scripts under scripts/ directory, add to setup.py (#489) d347527 Change PFC watchdog CONFIG_DB table name from PFC_WD_TABLE to PFC_WD (#475) Signed-off-by: Wenda Ni <wenni@microsoft.com>

…c-net#437) Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>

…c-net#437)

Includes sonic-swss-common commits: ``` 71dc350 2021-01-07 | Lower the log level for outdated key for SubscriberStateTable notification (sonic-net#441) [Qi Luo] 7e40582 2021-01-08 | Add boost dependencies (sonic-net#442) [Ze Gan] 30a8ddf 2021-01-05 | Change DBConnector::hgetall return type from map to unordered_map (sonic-net#440) [Qi Luo] 021108d 2021-01-02 | MCLAG Enhancements per HLD sonic-net/SONiC#596 (sonic-net#405) [Praveen-Brcm] 54996fc 2021-01-02 | Implement ConfigDBConnector and ConfigDBPipeConnector in C++ (sonic-net#437) [Qi Luo] 8286525 2020-12-27 | Simply refactor DBConnector hgetall() [Qi Luo] 6d1d33b 2020-12-27 | Fix RedisTransactioner: handle empty deque [Qi Luo] 624e0b8 2020-12-26 | Move complex class constructor as explicit, and fix several mistaken copy constructor usage [Qi Luo] 3b983f9 2020-12-30 | [ci]: add timeout to 180 minutes for arm build (sonic-net#439) [lguohan] f2e4210 2020-12-29 | Add utility for string and redis (sonic-net#434) [Ze Gan] 7a885fd 2020-12-29 | [build]: add build check for arm64 and armhf (sonic-net#436) [lguohan] 47bccc4 2020-12-24 | Add missed vector header to rediscommand.h (sonic-net#435) [Ze Gan] ```

Includes sonic-swss-common commits: ``` 71dc350 2021-01-07 | Lower the log level for outdated key for SubscriberStateTable notification (#441) [Qi Luo] 7e40582 2021-01-08 | Add boost dependencies (#442) [Ze Gan] 30a8ddf 2021-01-05 | Change DBConnector::hgetall return type from map to unordered_map (#440) [Qi Luo] 021108d 2021-01-02 | MCLAG Enhancements per HLD sonic-net/SONiC#596 (#405) [Praveen-Brcm] 54996fc 2021-01-02 | Implement ConfigDBConnector and ConfigDBPipeConnector in C++ (#437) [Qi Luo] 8286525 2020-12-27 | Simply refactor DBConnector hgetall() [Qi Luo] 6d1d33b 2020-12-27 | Fix RedisTransactioner: handle empty deque [Qi Luo] 624e0b8 2020-12-26 | Move complex class constructor as explicit, and fix several mistaken copy constructor usage [Qi Luo] 3b983f9 2020-12-30 | [ci]: add timeout to 180 minutes for arm build (#439) [lguohan] f2e4210 2020-12-29 | Add utility for string and redis (#434) [Ze Gan] 7a885fd 2020-12-29 | [build]: add build check for arm64 and armhf (#436) [lguohan] 47bccc4 2020-12-24 | Add missed vector header to rediscommand.h (#435) [Ze Gan] ```

…tomatically (#20503) #### Why I did it src/sonic-linux-kernel ``` * 6d0f01b - (HEAD -> master, origin/master, origin/HEAD) Fix RCU stall detected in kernel 6.1 when unregistering devlink (#437) (2 hours ago) [Vivek] * 32233e9 - Merge pull request #436 from vivekrnv/fix_w25q128 (9 hours ago) [bingwang-ms] * 6ef1f0b - Merge branch 'master' into fix_w25q128 (12 days ago) [Saikrishna Arcot] * b2b9ce9 - Fix for Winbond flash devices that could not parse SFDP (3 weeks ago) [Vivek Reddy] ``` #### How I did it #### How to verify it #### Description for the changelog

…tomatically (#20568) #### Why I did it src/sonic-linux-kernel ``` * 6411b03 - (HEAD -> 202405, origin/202405) Fix RCU stall detected in kernel 6.1 when unregistering devlink (#437) (63 minutes ago) [Vivek] * bd40662 - Fix for Winbond flash devices that could not parse SFDP (#440) (3 hours ago) [Vivek] ``` #### How I did it #### How to verify it #### Description for the changelog

…tomatically (sonic-net#20503) #### Why I did it src/sonic-linux-kernel ``` * 6d0f01b - (HEAD -> master, origin/master, origin/HEAD) Fix RCU stall detected in kernel 6.1 when unregistering devlink (sonic-net#437) (2 hours ago) [Vivek] * 32233e9 - Merge pull request sonic-net#436 from vivekrnv/fix_w25q128 (9 hours ago) [bingwang-ms] * 6ef1f0b - Merge branch 'master' into fix_w25q128 (12 days ago) [Saikrishna Arcot] * b2b9ce9 - Fix for Winbond flash devices that could not parse SFDP (3 weeks ago) [Vivek Reddy] ``` #### How I did it #### How to verify it #### Description for the changelog

…c-net#437) Resolves: sonic-net#20368 Ref: https://lore.kernel.org/stable/20241001112035.973187-1-idosch@nvidia.com/t/#u > But first of, why? Why not just take the upstrema commits instead? > > thanks, > greg k-h Ido: > There were a lot of changes as part of the 6.3 cycle to completely > rework the semantics of the devlink instance reference count. As part of > these changes, commit d77278196441 ("devlink: bump the instance index > directly when iterating") inadvertently fixed the bug mentioned in this > patch. This commit cannot be applied to 6.1.y as-is because a prior > commit (also in 6.3) moved the code to a different file (leftover.c -> > core.c). There might be more dependencies that I'm currently unaware of. > > The alternative, proposed in this patch, is to provide a minimal and > contained fix for the bug introduced in upstream commit c2368b19807a > ("net: devlink: introduce "unregistering" mark and use it during > devlinks iteration") as part of the 6.0 cycle. Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

[interface-config] Fix a loopback addr config bug

a40d54e

Fix a bug introduced in PR 430 that addresses on lo are not configured correctly.

taoyl-ms requested a review from stcheng March 25, 2017 00:56

stcheng approved these changes Mar 25, 2017

View reviewed changes

taoyl-ms merged commit 9e8df96 into master Mar 25, 2017

stcheng deleted the taoyl/lo_config branch March 25, 2017 01:13

stcheng added the Bug 🐛 label Mar 25, 2017

mykolaf mentioned this pull request Feb 4, 2019

[sonic-utilities] update submodule pointer #2523

Merged

yxieca mentioned this pull request Apr 1, 2019

[201811][sairedis][swss] advance sub module head of sairedis and swss #2728

Merged

wendani mentioned this pull request Apr 9, 2019

Submodule reference pointer change for PFC watchdog warm reboot commits #2755

Merged

Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019

[intfutil] add Asymmetric PFC status to 'show interface status' (soni…

c6666e2

…c-net#437) Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>

dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020

Notify OA about exception and process only restart query events (soni…

b138ff9

…c-net#437)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[interface-config] Fix a loopback addr config bug #437

[interface-config] Fix a loopback addr config bug #437

taoyl-ms commented Mar 25, 2017 •

edited

Loading

stcheng commented Mar 25, 2017

[interface-config] Fix a loopback addr config bug #437

[interface-config] Fix a loopback addr config bug #437

Conversation

taoyl-ms commented Mar 25, 2017 • edited Loading

stcheng commented Mar 25, 2017

taoyl-ms commented Mar 25, 2017 •

edited

Loading