-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Add essential PY PKGs on host for sonic-utilities/config/config_mgmt.py #4740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…config/config_mgmt.py. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
retest vsimage please |
@lguohan it will be helpful if we can merge this PR as well. |
lguohan
reviewed
Jun 23, 2020
lguohan
previously approved these changes
Jun 25, 2020
Thanks, Kindly merge it, I need to run tests based on this. |
…on.j2. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
jleveque
suggested changes
Jun 26, 2020
…ges. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
jleveque
approved these changes
Jun 26, 2020
retest vs please |
praveen-li
pushed a commit
to praveen-li/sonic-utilities
that referenced
this pull request
Jun 26, 2020
this pkg will come from sonic-net/sonic-buildimage#4740. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
retest vsimage please |
@jleveque |
jleveque
changed the title
[build_debian.sh]: Add essential PY PKGs on host for sonic-utilities/…
[build] Add essential PY PKGs on host for sonic-utilities/config/config_mgmt.py
Jun 28, 2020
pjaipakdee19
pushed a commit
to pjaipakdee19/sonic-buildimage
that referenced
this pull request
Jul 7, 2020
…ig_mgmt.py (sonic-net#4740) Add essential PY PKGs on host by installing them in sonic_debian_extension.j2 Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…config/config_mgmt.py.
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
- Why I did it
TO run sonic-utilities/config/config_mgmt.py on host.
- How I did it
Add essential PY PKGs on host by adding them in sonic_debian_extension.j2
- How to verify it
#4684 was built fine with these changes. [These changes are removed from PR 4684 and then added here.]
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)