Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Add essential PY PKGs on host for sonic-utilities/config/config_mgmt.py #4740

Merged
merged 3 commits into from
Jun 28, 2020

Conversation

praveen-li
Copy link
Member

@praveen-li praveen-li commented Jun 9, 2020

…config/config_mgmt.py.

Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com

- Why I did it
TO run sonic-utilities/config/config_mgmt.py on host.

- How I did it
Add essential PY PKGs on host by adding them in sonic_debian_extension.j2

- How to verify it
#4684 was built fine with these changes. [These changes are removed from PR 4684 and then added here.]

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

…config/config_mgmt.py.

Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
@praveen-li
Copy link
Member Author

retest vsimage please

@praveen-li
Copy link
Member Author

@lguohan it will be helpful if we can merge this PR as well.

build_debian.sh Outdated Show resolved Hide resolved
lguohan
lguohan previously approved these changes Jun 25, 2020
@praveen-li
Copy link
Member Author

@jleveque

Thanks, Kindly merge it, I need to run tests based on this.

…on.j2.

Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
…ges.

Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
@praveen-li
Copy link
Member Author

retest vs please

praveen-li pushed a commit to praveen-li/sonic-utilities that referenced this pull request Jun 26, 2020
this pkg will come from sonic-net/sonic-buildimage#4740.

Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
@lguohan
Copy link
Collaborator

lguohan commented Jun 27, 2020

retest vsimage please

@praveen-li
Copy link
Member Author

@jleveque
All tests are done, now. We should be good to merge. Thanks.

@jleveque jleveque changed the title [build_debian.sh]: Add essential PY PKGs on host for sonic-utilities/… [build] Add essential PY PKGs on host for sonic-utilities/config/config_mgmt.py Jun 28, 2020
@jleveque jleveque merged commit 07930c3 into sonic-net:master Jun 28, 2020
pjaipakdee19 pushed a commit to pjaipakdee19/sonic-buildimage that referenced this pull request Jul 7, 2020
…ig_mgmt.py (sonic-net#4740)

Add essential PY PKGs on host by installing them in sonic_debian_extension.j2

Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants