[201911] Fix issues with sonic-py-common package #5191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a) we should use get_platform() with new sonic_py-common package b) In 201911 DB Connector is still using db id based constructor as following PR sonic-net#4549 is not cherry-picked yet. So revert the change to use db is insatead of db_name for now. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
jleveque
approved these changes
Aug 15, 2020
|
what kind of test can catch this? |
|
As the final step of the transition to sonic-py-common, I indend to add unit tests (see: #4999) which can be run at package build time. Whenever anyone adds new functions like these to the library, we should ensure 100% test coverage before merging the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Two fixes/change were made with new sonic-py-common package:
a) we should use get_platform() with new sonic_py-common package
instead of get_platform_info()
b) In 201911 DB Connector is still using db id based constructor
as following PR##4549
is not cherry-picked yet.
So revert the change to use db is instead of db_name for now. This will be updated when we move to db name
How I verified:
Because of (b) PMON process were bailing out. After fix things are fine.