-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[files/build]: Support reproduceable build for docker image #5895
[files/build]: Support reproduceable build for docker image #5895
Conversation
retest broadcom please #Closed |
retest mellanox please #Closed |
retest this please #Closed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As comments
retest this please #ByDesign |
2 similar comments
retest this please #ByDesign |
retest this please #ByDesign |
src/sonic-build-hooks/hooks/j2
Outdated
@@ -0,0 +1,63 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may not need to hook the j2 script, we only want to change the Dockerfile file. I suggest change Makefile only, not to hook the j2 script.
- Why I did it
Some component's make process uses thirdparty docker image by "FROM" in Dockerfile. They use image and tag to specify a docker image. When the image with the same tag changed, build process may fail.
- How I did it
But when you want to use latest docker image, set parameter 'SONIC_VERSION_CONTROL_COMPONENTS ' and build. At last replace the hash value in 'files/build/versions/versions-docker' by 'files/build/versions/versions-docker-latest'.
- How to verify it
'files/build/versions/versions-docker.log' will record some infomation.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
support version control of the docker image
- A picture of a cute animal (not mandatory but encouraged)